Node log query

[aravindhp]

Enhancement Description

• Add a kubelet API for viewing logs of system services on nodes

• Kubernetes Enhancement Proposal: KEP-2258: Node log query

• Discussion Link: https://kubernetes.slack.com/archives/C0SJ4AFB7/p1610055846236600

• Primary contact (assignee): @aravindhp

• Responsible SIGs: sig-windows

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y): 1.27
  • Beta release target (x.y): 1.30
  • Stable release target (x.y): 1.32

• Alpha

  • KEP (k/enhancements) update PR(s): KEP 2258: Node service log viewer #2271
  • Code (k/k) update PR(s):
    • KEP 2258: add node log query kubernetes#96120
  • Docs (k/website) update PR(s): KEP-2258: Node log query documentation website#40003

• Beta

  • KEP (k/enhancements) update PR(s): KEP-2258: Promote NodeLogQuery to beta #4480
  • Code (k/k) update PR(s):
    • Fix systemd unit string matches kubernetes#120678
    • test: Fix NodeLogQuery tests kubernetes#121707
    • e2e: only select linux nodes for NodeLogQuery tests kubernetes#122240
    • e2e: add NodeLogQuery tests for Windows nodes kubernetes#122594
    • features: promote NodeLogQuery to beta kubernetes#123205
  • Docs:
    • KEP-2258: Promote NodeLogQuery to beta website#45126
  • kubectl plugin: kubectl-node-logs

[aravindhp]

/cc @LorbusChris @marosset @immuzz
/sig windows

[dougsland]

/cc

[annajung]

Hi @aravindhp

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2271). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

• [IN PROGRESS] The KEP must be merged in an implementable state
• [IN PROGRESS] The KEP must have test plans
• [IN PROGRESS] The KEP must have graduation criteria
• [IN PROGRESS] The KEP must have a production readiness review

[aravindhp]

@annajung #2271 has the following completed:
[IN PROGRESS] The KEP must have test plans
[IN PROGRESS] The KEP must have graduation criteria
[IN PROGRESS] The KEP must have a production readiness review (I need update the check mark but it has been /approved for PRR)
Is there a reason for it to be marked IN PROGRESS?

[annajung]

@aravindhp We consider it in progress until PR merges. Even if you have a PR open for the change, if it doesn't merge before the enhancements freeze, this enhancement is at risk of not making it into the release.

[aravindhp]

Thanks for the clarification @annajung. We are waiting for LGTMs from sig-node and sig-auth to merge.

[annajung]

Hi @aravindhp,

Enhancements Freeze is now in effect.

Unfortunately, your KEP needed to be updated and the PR has not yet merged. If you wish to be included in the 1.21 Release, please submit an Exception Request as soon as possible.

/milestone clear

[immuzz]

This is very much needed especially for scenarios where you need to access host like gMSA for Windows Containers. Cant wait to see this land soon

[salaxander]

Hi @aravindhp , 1.22 enhancements team here!

For the enhancement to be included in the milestone, it must meet the following criteria:

[DONE] The KEP must be merged in an implementable state
[DONE] The KEP must have test plans
[DONE] The KEP must have graduation criteria
[DONE] The KEP must have a production readiness review

Looks like we're in good shape for enhancements freeze on 5/13. Let us know if there's anything we can do to help before then!

Thanks!!

[salaxander]

Hey @aravindhp - Just checking in as we're about 2 weeks away from 1.22 code freeze. Are there any open or merged k/k PRs we should be tracking for this? Thanks!

[aravindhp]

@salaxander, I have a WIP PR: kubernetes/kubernetes#96120. But it is looking very tight at this point.

[salaxander]

Hi @aravindhp - One more check-in as we're a week out from code freeze. Any updates on if you expect kubernetes/kubernetes#96120 to merge before the deadline?

Thanks!

[LorbusChris]

By now, I don't think it's reasonable to assume it will make it in in time. We will circle back to this in the next Dev window.

[marosset]

/milestone clear

[aravindhp]

@sreeram-venkitesh I have updated the milestone in

• KEP-2258: Promote NodeLogQuery to beta #4480

[salehsedghpour]

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

[Princesso]

Hello @aravindhp, 👋 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[aravindhp]

@Princesso I have opened:

• KEP-2258: Promote NodeLogQuery to beta website#45126

[Checksumz]

Hi @aravindhp ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

[aravindhp]

@Checksumz I already blogged about the feature when it was added as alpha. No changes to the feature from alpha to beta. I will do a blog when it graduates to GA.

[Checksumz]

Thanks for the response @aravindhp

[mrunalp]

/stage beta

[sreeram-venkitesh]

Hey again @aravindhp 👋 v1.30 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, with below PRs merged as per the issue description, this enhancement is now marked as Tracked for code freeze for the 1.30 Code Freeze! 🚀

• Fix systemd unit string matches kubernetes#120678
• test: Fix NodeLogQuery tests kubernetes#121707
• e2e: only select linux nodes for NodeLogQuery tests kubernetes#122240
• e2e: add NodeLogQuery tests for Windows nodes kubernetes#122594
• features: promote NodeLogQuery to beta kubernetes#123205

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

[sreeram-venkitesh]

Hi @aravindhp 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[aravindhp]

/remove-lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[kannon92]

/remove-lifecycle stale