-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communicate replica set and deployment status via conditions #120
Comments
Can we also include DaemonSets here? I can help with implementation. |
I would prefer to keep the work for other controllers separate from RS/D. |
@smarterclayton can you confirm that this feature has been fully implemented and the issue can be closed? |
@idvoretskyi yes, this issue should be good to go. Any follow-up work should happen in #122 which has some overlap with this one. |
…ivate Create Installer enhancement for GCP private/internal clusters.
So administrators have some idea at how to debug, when they notice that status.numberMisscheduled > 0, e.g. because KubeDaemonSetMisScheduled is firing. Ideally we'd have status.conditions on DaemonSet [1], so we could declare things like this in a more discoverable location. But while logs aren't all that discoverable, they are easier to add than a new DaemonSet property. And we can mitigate discoverability by filling out [2] and linking [3] a runbook to recommend grepping the controller logs for this message. [1]: kubernetes/enhancements#120 (comment) [2]: https://github.com/kubernetes-monitoring/kubernetes-mixin/blob/5c2dd2c63c8d655bdb7717f695d02bd22bd180e8/runbook.md#alert-name-kubedaemonsetmisscheduled [3]: https://github.com/kubernetes-monitoring/kubernetes-mixin/blob/5c2dd2c63c8d655bdb7717f695d02bd22bd180e8/alerts/apps_alerts.libsonnet#L224-L237
Description
Deployments and replica sets are the key components of the system for ensuring pods are being created and maintained, but it is currently difficult to summarize / roll-up the status of the RS/D during operation. In addition, certain cluster policies like quota, limit range, or pod security policy can prevent pod creation, but the failures are only shown through events. This change will expose more information directly in RS / D status about recent failures on the RS/D, giving clients summarized info that problems are occurring.
Progress Tracker
/pkg/apis/...
)@kubernetes/api
@kubernetes/docs
on docs PR@kubernetes/feature-reviewers
on this issue to get approval before checking this off@kubernetes/docs
on docs PR@kubernetes/feature-reviewers
on this issue to get approval before checking this off@kubernetes/api
@kubernetes/feature-reviewers
on this issue to get approval before checking this off@kubernetes/docs
@kubernetes/feature-reviewers
on this issue to get approval before checking this offFEATURE_STATUS is used for feature tracking and to be updated by
@kubernetes/feature-reviewers
.FEATURE_STATUS: IN_DEVELOPMENT
More advice:
Design
@kubernetes/feature-reviewers
member, you can check this checkbox, and the reviewer will apply the "design-complete" label.Coding
and sometimes http://github.com/kubernetes/contrib, or other repos.
@kubernetes/feature-reviewers
and they willcheck that the code matches the proposed feature and design, and that everything is done, and that there is adequate
testing. They won't do detailed code review: that already happened when your PRs were reviewed.
When that is done, you can check this box and the reviewer will apply the "code-complete" label.
Docs
@kubernetes/docs
.The text was updated successfully, but these errors were encountered: