Skip to content

Commit 6dc5fd1

Browse files
committed
Fix prr's comment
1 parent 74ce411 commit 6dc5fd1

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
kep-number: 3721
22
alpha:
3-
approver: "@jpbetz"
3+
approver: "@soltysh"

keps/sig-node/3721-support-for-env-files/README.md

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -446,10 +446,11 @@ with this new fields:
446446

447447
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
448448

449-
Automated tests will cover the scenarios with and without the changes proposed
450-
on this KEP. As defined under [Version Skew Strategy](#version-skew-strategy),
449+
We will manually attempt an upgrade-downgrade test with the following scenario.
450+
451+
As defined under [Version Skew Strategy](#version-skew-strategy),
451452
we are assuming the cluster may have kubelets with older versions (without
452-
this KEP' changes), therefore this will be covered of following new tests:
453+
this KEP' changes):
453454

454455
1. When the kubelet is upgraded, the env files will be instantiated in the
455456
container. On downgrade, the env files will be ignored but the pod will still
@@ -483,15 +484,17 @@ CONFIG_VAR=HELLO
483484

484485
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
485486

486-
N/A
487+
SLI: Startup latency of schedulable stateful pods, excluding time to pull images, run init containers, provision volumes (in delayed binding mode) and unmount/detach volumes (from previous pod if needed), measured from pod creation timestamp to when all its containers are reported as started and observed via watch, measured as 99th percentile over last 5 minutes.
488+
489+
SLO: In default Kubernetes installation, 99th percentile per cluster-day1 <= X where X depends on storage provider
487490

488491
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
489492

490-
N/A
493+
We can determine whether the service is healthy by checking if the started_containers_errors_total and started_pods_errors_total metrics are abnormally increasing.
491494

492495
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
493496

494-
N/A
497+
No
495498

496499
### Dependencies
497500

@@ -515,7 +518,7 @@ No
515518

516519
###### Will enabling / using this feature result in increasing size or count of the existing API objects?
517520

518-
No
521+
We have added the `fileKeyRef` data structure to `podSpec`, which will undoubtedly increase the size of the Pod API. The increase in size depends on the number of environment variables defined by the user, making it impossible to estimate the exact number of bytes added. However, this should not have a significant impact on the API. For many users, it merely involves migrating environment variables previously defined in `ConfigMap/Secret` to this new structure.
519522

520523
###### Will enabling / using this feature result in increasing time taken by any operations covered by existing SLIs/SLOs?
521524

@@ -527,7 +530,7 @@ No
527530

528531
###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
529532

530-
No
533+
Environment variables are not typically associated with PIDs, sockets, or inodes. However, non-standard usage patterns may introduce risks. For example: if expanded variables are used to launch numerous network services or open excessive file descriptors (e.g., environment variables defining large numbers of port numbers), this could indirectly lead to socket exhaustion.
531534

532535
### Troubleshooting
533536

keps/sig-node/3721-support-for-env-files/kep.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ feature-gates:
3737
components:
3838
- kube-apiserver
3939
- kubelet
40-
disable-supported: false
40+
disable-supported: true
4141

4242
# The following PRR answers are required at beta release
4343
metrics:
44-
- N/A
44+
- started_containers_errors_total
45+
- started_pods_errors_total

0 commit comments

Comments
 (0)