Skip to content

Commit 406e8eb

Browse files
Update ControllerModifyVolume Status API
1 parent 8ec8fa2 commit 406e8eb

File tree

1 file changed

+10
-5
lines changed
  • keps/sig-storage/3751-volume-attributes-class

1 file changed

+10
-5
lines changed

keps/sig-storage/3751-volume-attributes-class/README.md

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,22 +177,27 @@ type PersistentVolumeClaimStatus struct {
177177
...
178178
// The VolumeAttributesClassName string cannot be empty
179179
VolumeAttributesClassName string
180-
ModifyVolumeStatus *PersistentVolumeClaimModifyVolumeStatus
180+
ModifyVolumeStatus ModifyVolumeStatus
181181
...
182182
}
183183
184+
type ModifyVolumeStatus struct {
185+
ActualClassName string
186+
TargetClassName string
187+
Status *PersistentVolumeClaimModifyVolumeStatus
188+
}
189+
184190
// +enum
185191
type PersistentVolumeClaimModifyVolumeStatus string
186192
187193
const (
188194
// When modify volume is complete, the empty string is set by modify volume controller.
189-
PersistentVolumeClaimNoModifyVolumeInProgress PersistentVolumeClaimModifyVolumeStatus = ""
195+
PersistentVolumeClaimNoModifyVolumeInSucceeded PersistentVolumeClaimModifyVolumeStatus = ""
190196
// State set when modify volume controller starts modifying the volume in control-plane
197+
// Non terminal errors should also keep this status without modification
191198
PersistentVolumeClaimControllerModifyVolumeInProgress PersistentVolumeClaimModifyVolumeStatus = "ControllerModifyVolumeInProgress"
192199
// State set when modify volume has failed in modify volume controller with a terminal error.
193-
// Transient errors such as timeout should not set this status and should leave ModifyVolumeStatus
194-
// unmodified, so as modify volume controller can resume the volume modification.
195-
PersistentVolumeClaimControllerModifyVolumeFailed PersistentVolumeClaimModifyVolumeStatus = "ControllerModifyVolumeFailed"
200+
PersistentVolumeClaimControllerModifyVolumeInfeasible PersistentVolumeClaimModifyVolumeStatus = "ControllerModifyVolumeInfeasible"
196201
)
197202
198203
```

0 commit comments

Comments
 (0)