Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add full support for labels and annotations in helm chart #9490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tuunit
Copy link

@tuunit tuunit commented Sep 27, 2024

Motivation

For Operators like ArgoCD or Teleport it is quite useful and sometimes necessary to be able to control and insert annotations and labels into all kinds of resources and especially services.

Furthermore the documentation in the values.yaml was wrong in some places.

  • The common labels and annotations aren't applied to all resources.
  • Some comments mentioned the wrong resources like "Labels & Annotations for API" despite living in the "Auth" block

Description

  • Remove unnecessary templating function common.tpl.renders
  • Add new helper function kubernetes-dashboard.annotations to apply common annotations to all resources
  • Add common app.labels to helper function kubernetes-dashboard.labels
  • Add auth, api, web, and metricsScraper labels and annotation options to all their respective resources
  • Add a two new options serviceLabels and serviceAnnotations to auth, api, web, and metricsScraper services

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @tuunit!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tuunit
Once this PR has been reviewed and has the lgtm label, please assign desaintmartin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuunit tuunit changed the title feat: add full support for label and annotation in helm chart feat: add full support for labels and annotations in helm chart Sep 27, 2024
@tuunit
Copy link
Author

tuunit commented Sep 27, 2024

@desaintmartin @floreks let me know what you think of this change and if I should increase the Chart version as part of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants