Skip to content

Commit e27569b

Browse files
committed
Review updates
1 parent 4a0dc2b commit e27569b

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

contributors/design-proposals/storage/container-storage-interface-inline-volumes.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Author: @jsafrane
99
Currently, CSI can be used only though PersistentVolume object. All other persistent volume sources support in-line volumes in Pods, CSI should be no exception. There are two main drivers:
1010
* We want to move away from in-tree volume plugins to CSI, as designed in a separate proposal https://github.com/kubernetes/community/pull/2199/. In-line volumes should use CSI too.
1111
* CSI drivers can be used to provide Secrets-like volumes to pods, e.g. providing secrets from a remote vault. We don't want to force users to create PVs for each secret, we should allow to use them in-line in pods as regular Secrets or Secrets-like Flex volumes.
12+
* Get the same features as Flex and deprecate Flex. I.e. replace it with some CSI-Flex bridge, which is out of scope of this proposal.
1213

1314
## API
1415
`VolumeSource` needs to be extended with CSI volume source:
@@ -28,9 +29,9 @@ type CSIVolumeSource struct {
2829
// Required.
2930
Driver string
3031

31-
// VolumeHandle is the unique volume name returned by the CSI volume
32-
// plugin’s CreateVolume to refer to the volume on all subsequent calls.
33-
// Required.
32+
// VolumeHandle is the unique ID of the volume. It is the ID used in all CSI
33+
// calls.
34+
// Required
3435
VolumeHandle string
3536

3637
// Optional: The value to pass to ControllerPublishVolumeRequest.
@@ -44,7 +45,8 @@ type CSIVolumeSource struct {
4445
// +optional
4546
FSType string
4647

47-
// Attributes of the volume to publish.
48+
// Attributes of the volume. This corresponds to "volume_attributes" in some
49+
// CSI calls.
4850
// +optional
4951
VolumeAttributes map[string]string
5052

0 commit comments

Comments
 (0)