Removed error logging from config loader

[vr4manta]

What this PR does / why we need it:

• Reduces misleading error message that may cause confusion when users glance through the logs

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1224

Special notes for your reviewer:

This PR adds a check to see if byte data is YAML. If so, it will call the parse yaml like before allowing any errors to be logged. I believe this is enough to just state the YAML attempt failed and is falling back onto INI config load.

Release note:

None

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: vr4manta / name: Neil Girard (fa11631)

[k8s-ci-robot]

Welcome @vr4manta!

It looks like this is your first PR to kubernetes/cloud-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @vr4manta. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[XudongLiuHarold]

Hi @vr4manta

Thank you for your PR! My cents:

• It would be better to begin deprecating the INI configuration, as we plan to remove support for it in the future.

• IMO, a better approach to resolving this issue might be to add a method that checks the configuration file format: https://github.com/kubernetes/cloud-provider-vsphere/blob/master/pkg/common/config/config.go#L261, rather than removing the error log from the YAML parser.

[vr4manta]

Hi @vr4manta

Thank you for your PR! My cents:

• It would be better to begin deprecating the INI configuration, as we plan to remove support for it in the future.
• IMO, a better approach to resolving this issue might be to add a method that checks the configuration file format: https://github.com/kubernetes/cloud-provider-vsphere/blob/master/pkg/common/config/config.go#L261, rather than removing the error log from the YAML parser.

Hi @XudongLiuHarold. Thanks for the feedback. We are enhancing our installer to make new installs use YAML, but all existing clusters are up to the admins to update the config. If they are doing something like multi vCenter, we are requiring them to upgrade from INI to YAML by hand for now. But all customers with one failure domain or all failure domains in one vCenter are not currently required to migrate the cloud provider config.

Based on that, I think it would be perfectly fine to do a new function that checks to see if the file is YAML format in the above linked function. I can look into putting something there that can do a quick check.

[XudongLiuHarold]

/ok-to-test

[gnufied]

/lgtm

[XudongLiuHarold]

e2e test passed: team-cluster-api#60

[elmiko]

code makes sense to me, even if the ini format is being deprecated it would be nice to reduce confusion in the logs.

[vr4manta]

/assign @XudongLiuHarold
I think this is ready for approval. Thanks.

[XudongLiuHarold]

/lgtm

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vr4manta, XudongLiuHarold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [XudongLiuHarold]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment