test/e2e: use vSphere projects from Boskos #1067
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
do-not-merge/hold
|
cc @chrischdi @fabriziopandini |
|
/test ? |
|
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cloud-provider-vsphere-e2e-test |
|
/test pull-cloud-provider-vsphere-e2e-test (forgot to change the network) |
|
/assign @fabriziopandini @chrischdi @XudongLiuHarold Ready for review :) |
|
/test pull-cloud-provider-vsphere-e2e-test |
|
/test pull-cloud-provider-vsphere-e2e-test |
|
/hold /assign @lubronzhan @XudongLiuHarold Please let me know if you need more information than is provided on the linked issues /assign @fabriziopandini @chrischdi |
|
/test pull-cloud-provider-vsphere-e2e-test |
Signed-off-by: Stefan Büringer buringerst@vmware.com
There was a problem hiding this comment.
/lgtm
generally looks great, thanks @sbueringer !
We might want to change this docker image: gcr.io/k8s-staging-capi-vsphere/extra/boskosctl:latest to cloud-provider-vsphere registry to avoid more coupling with capv, but I can do that in a follow-up PR once I pushed this image.
k8s-ci-robot
added
the
lgtm
I would prefer to use the same image as we use in CAPV. That allows us - as CAPV maintainers - to easily maintain the vSphere environment for CAPV, image-builder and cloud-provider-vsphere. |
|
/test pull-cloud-provider-vsphere-e2e-test |
|
@XudongLiuHarold @lubronzhan Please also put this on the list of PRs that have to be backported to all branches for which you still want to run CI (like: #1063) |
|
/test pull-cloud-provider-vsphere-e2e-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, XudongLiuHarold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
For context see: kubernetes-sigs/cluster-api-provider-vsphere#3034
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: