From d3c456142cbe30068c9a4a5aa073546e31c00e56 Mon Sep 17 00:00:00 2001 From: xudong liu Date: Tue, 28 May 2024 10:23:43 +0530 Subject: [PATCH] clean up and remove all targets and scripts to push image for vmware registry Signed-off-by: xudong liu --- Makefile | 16 -- hack/ensure-kubectl.sh | 54 ------- hack/images/ci/Makefile | 5 - hack/images/ci/README.md | 11 -- hack/make/login-to-image-registry.mk | 29 ---- hack/release.sh | 220 --------------------------- 6 files changed, 335 deletions(-) delete mode 100755 hack/ensure-kubectl.sh delete mode 100644 hack/make/login-to-image-registry.mk delete mode 100755 hack/release.sh diff --git a/Makefile b/Makefile index adbac293e..fe2be932c 100644 --- a/Makefile +++ b/Makefile @@ -315,19 +315,6 @@ staticcheck: vet: hack/check-vet.sh -################################################################################ -## BUILD IMAGES AND BINARIES ## -################################################################################ -.PHONY: release -release: | $(DOCKER_SOCK) - hack/release.sh - -################################################################################ -## PUSH IMAGES AND BINARIES ## -################################################################################ -.PHONY: release-push -release-push: | $(DOCKER_SOCK) - hack/release.sh -p ################################################################################ ## CI IMAGE ## @@ -335,9 +322,6 @@ release-push: | $(DOCKER_SOCK) build-ci-image: $(MAKE) -C hack/images/ci build -push-ci-image: - $(MAKE) -C hack/images/ci push - print-ci-image: @$(MAKE) --no-print-directory -C hack/images/ci print diff --git a/hack/ensure-kubectl.sh b/hack/ensure-kubectl.sh deleted file mode 100755 index be5c12592..000000000 --- a/hack/ensure-kubectl.sh +++ /dev/null @@ -1,54 +0,0 @@ -#!/usr/bin/env bash - -# Copyright 2021 The Kubernetes Authors. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -set -o errexit -set -o nounset -set -o pipefail - -GOPATH_BIN="$(go env GOPATH)/bin/" -MINIMUM_KUBECTL_VERSION=v1.16.7 - -# Ensure the kubectl tool exists and is a viable version, or installs it -verify_kubectl_version() { - - # If kubectl is not available on the path, get it - if ! [ -x "$(command -v kubectl)" ]; then - if [[ "${OSTYPE}" == "linux-gnu" ]]; then - if ! [ -d "${GOPATH_BIN}" ]; then - mkdir -p "${GOPATH_BIN}" - fi - echo 'kubectl not found, installing' - curl -sLo "${GOPATH_BIN}/kubectl" https://dl.k8s.io/release/${MINIMUM_KUBECTL_VERSION}/bin/linux/amd64/kubectl - chmod +x "${GOPATH_BIN}/kubectl" - else - echo "Missing required binary in path: kubectl" - return 2 - fi - fi - - local kubectl_version - IFS=" " read -ra kubectl_version <<< "$(kubectl version --client --short)" - if [[ "${MINIMUM_KUBECTL_VERSION}" != $(echo -e "${MINIMUM_KUBECTL_VERSION}\n${kubectl_version[2]}" | sort -s -t. -k 1,1 -k 2,2n -k 3,3n | head -n1) ]]; then - cat </dev/null 2>&1 || \ - { echo 'gcloud auth helper unavailable' 1>&2; exit 1; } - @grep -F 'gcr.io": "gcloud"' "$(HOME)/.docker/config.json" >/dev/null 2>&1 || \ - { gcloud auth configure-docker --quiet || \ - { echo 'gcloud helper registration failed' 1>&2; exit 1; }; } - @echo "logging into gcr.io registry with gcloud auth helper" -endif # end gcr.io-gcloud / end gcr.io -# Push images to a Docker registry. -else # begin docker -# Log into the registry with a Docker username and password. -ifneq (,$(strip $(DOCKER_USERNAME))) # begin docker-username -ifneq (,$(strip $(DOCKER_PASSWORD))) # begin docker-password - @echo "logging into docker registry with username and password" - docker login -u="$(DOCKER_USERNAME)" -p="$(DOCKER_PASSWORD)" -endif # end docker-password -endif # end docker-username -endif # end docker \ No newline at end of file diff --git a/hack/release.sh b/hack/release.sh deleted file mode 100755 index b70da467c..000000000 --- a/hack/release.sh +++ /dev/null @@ -1,220 +0,0 @@ -#!/bin/bash - -# Copyright 2019 The Kubernetes Authors. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -# This script is used build new container images of the CAPV manager and -# clusterctl. When invoked without arguments, the default behavior is to build -# new ci images - -set -o errexit -set -o nounset -set -o pipefail - -# BASE_REPO is the root path of the image repository -readonly BASE_IMAGE_REPO=${BASE_IMAGE_REPO:-gcr.io/cloud-provider-vsphere} - -# Release images -readonly CPI_IMAGE_RELEASE=${CPI_IMAGE_RELEASE:-${BASE_IMAGE_REPO}/cpi/release/manager} - -# PR images -readonly CPI_IMAGE_PR=${CPI_IMAGE_PR:-${BASE_IMAGE_REPO}/cpi/pr/manager} - -# CI images -readonly CPI_IMAGE_CI=${CPI_IMAGE_CI:-${BASE_IMAGE_REPO}/cpi/ci/manager} - -AUTH= -PUSH= -CPI_IMAGE_NAME= -VERSION=$(git describe --dirty --always 2>/dev/null) -GCR_KEY_FILE="${GCR_KEY_FILE:-}" -GOPROXY="${GOPROXY:-}" -BUILD_RELEASE_TYPE="${BUILD_RELEASE_TYPE:-}" - -# If BUILD_RELEASE_TYPE is not set then check to see if this is a PR -# or release build. This may still be overridden below with the "-t" flag. -if [ -z "${BUILD_RELEASE_TYPE}" ]; then - if hack/match-release-tag.sh >/dev/null 2>&1; then - BUILD_RELEASE_TYPE=release - else - BUILD_RELEASE_TYPE=ci - fi -fi - -USAGE=" -usage: ${0} [FLAGS] - Builds and optionally pushes new images for vSphere CPI manager - - Honored environment variables: - GCR_KEY_FILE - GOPROXY - BUILD_RELEASE_TYPE - -FLAGS - -h show this help and exit - -k path to GCR key file. Used to login to registry if specified - (defaults to: ${GCR_KEY_FILE}) - -p push the images to the public container registry - -t the build/release type (defaults to: ${BUILD_RELEASE_TYPE}) - one of [ci,pr,release] -" - -# Change directories to the parent directory of the one in which this -# script is located. -cd "$(dirname "${BASH_SOURCE[0]}")/.." - -function error() { - local exit_code="${?}" - echo "${@}" 1>&2 - return "${exit_code}" -} - -function fatal() { - error "${@}" || exit 1 -} - -function build_images() { - case "${BUILD_RELEASE_TYPE}" in - ci) - # A non-PR, non-release build. This is usually a build off of master - CPI_IMAGE_NAME=${CPI_IMAGE_CI} - ;; - pr) - # A PR build - CPI_IMAGE_NAME=${CPI_IMAGE_PR} - ;; - release) - # On an annotated tag - CPI_IMAGE_NAME=${CPI_IMAGE_RELEASE} - ;; - esac - - echo "building ${CPI_IMAGE_NAME}:${VERSION}" - echo "GOPROXY=${GOPROXY}" - docker build \ - -f cluster/images/controller-manager/Dockerfile \ - -t "${CPI_IMAGE_NAME}:${VERSION}" \ - --build-arg "VERSION=${VERSION}" \ - --build-arg "GOPROXY=${GOPROXY}" \ - . -} - -function logout() { - if [ "${AUTH}" ]; then - gcloud auth revoke - fi -} - -function login() { - # If GCR_KEY_FILE is set, use that service account to login - if [ "${GCR_KEY_FILE}" ]; then - trap logout EXIT - gcloud auth configure-docker --quiet || fatal "unable to add docker auth helper" - gcloud auth activate-service-account --key-file "${GCR_KEY_FILE}" || fatal "unable to login" - docker login -u _json_key --password-stdin https://gcr.io <"${GCR_KEY_FILE}" || fatal "unable to login" - AUTH=1 - fi -} - -function push_images() { - [ "${CPI_IMAGE_NAME}" ] || fatal "CPI_IMAGE_NAME not set" - - login - - tag_exists=$(gcloud container images describe "${CPI_IMAGE_NAME}":"${VERSION}" > /dev/null; echo $?) - - if [[ "$tag_exists" -eq 0 ]]; then - echo "${CPI_IMAGE_NAME}:${VERSION} already exists, skip pushing" - else - echo "pushing ${CPI_IMAGE_NAME}:${VERSION}" - docker push "${CPI_IMAGE_NAME}":"${VERSION}" - fi -} - -function build_ccm_bin() { - echo "building ccm binary" - GOOS=linux GOARCH=amd64 make build-bins -} - -function sha_sum() { - { sha256sum "${1}" || shasum -a 256 "${1}"; } 2>/dev/null > "${1}.sha256" -} - -function push_ccm_bin() { - local bucket="vsphere-cpi-${BUILD_RELEASE_TYPE}" - - if gsutil -q stat "gs://${bucket}/${VERSION}/bin/linux/amd64/vsphere-cloud-controller-manager"; then - echo "gs://${bucket}/${VERSION}/bin/linux/amd64/vsphere-cloud-controller-manager exists, skip pushing" - else - sha_sum ".build/bin/vsphere-cloud-controller-manager.linux_amd64" - echo "copying ccm version ${VERSION} to ${bucket}" - gsutil cp ".build/bin/vsphere-cloud-controller-manager.linux_amd64" "gs://${bucket}/${VERSION}/bin/linux/amd64/vsphere-cloud-controller-manager" - gsutil cp ".build/bin/vsphere-cloud-controller-manager.linux_amd64.sha256" "gs://${bucket}/${VERSION}/bin/linux/amd64/vsphere-cloud-controller-manager.sha256" - fi -} - -# Start of main script -while getopts ":hk:pt:" opt; do - case ${opt} in - h) - error "${USAGE}" && exit 1 - ;; - k) - GCR_KEY_FILE="${OPTARG}" - ;; - p) - PUSH=1 - ;; - t) - BUILD_RELEASE_TYPE="${OPTARG}" - ;; - \?) - error "invalid option: -${OPTARG} ${USAGE}" && exit 1 - ;; - :) - error "option -${OPTARG} requires an argument" && exit 1 - ;; - esac -done -shift $((OPTIND-1)) - -# Verify the GCR_KEY_FILE exists if defined -if [ "${GCR_KEY_FILE}" ]; then - [ -e "${GCR_KEY_FILE}" ] || fatal "key file ${GCR_KEY_FILE} does not exist" -fi - -# Validate build/release type. -case "${BUILD_RELEASE_TYPE}" in - ci|pr|release) - # do nothing - ;; - *) - fatal "invalid BUILD_RELEASE_TYPE: ${BUILD_RELEASE_TYPE}" - ;; -esac - -# make sure that Docker is available -docker ps >/dev/null 2>&1 || fatal "Docker not available" - -# build container images -build_images - -# build CCM binary -build_ccm_bin - -# Optionally push artifacts -if [ "${PUSH}" ]; then - push_images - push_ccm_bin -fi