-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT REVIEW]add nodetopology CRD dependency and update vendor #781
base: master
Are you sure you want to change the base?
[DO NOT REVIEW]add nodetopology CRD dependency and update vendor #781
Conversation
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @YifeiZhuang! |
Hi @YifeiZhuang. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: YifeiZhuang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bring in nodetopology CRD dependency from GoogleCloudPlatform/gke-networking-api#22
Due to transit dependency, we have to upgrade
k8s.io/go-client
dependency version.go get github.com/GoogleCloudPlatform/gke-networking-api/client/nodetopology/clientset/versioned/typed/nodetopology/v1
go get github.com/GoogleCloudPlatform/gke-networking-api/client/nodetopology/clientset/versioned
go get github.com/GoogleCloudPlatform/gke-networking-api/apis/nodetopology/v1
./tools/update_vendor.sh