Add huaweicloud to list of supported cloud providers

[ysy2020]

Huawei Cloud Container Engine (CCE) provides highly scalable, high-performance, enterprise-class Kubernetes clusters and supports Docker containers. With CCE, you can easily deploy, manage, and scale containerized applications on HUAWEI CLOUD.

This PR adds Huawei Cloud Provider to support cluster autoscaler for Huawei CCE.

[ysy2020]

/assign @losipiuk

[ysy2020]

Hi @feiskyer @Jeffwan @losipiuk , did you get a chance to look at this? Do you have any concerns or comments on this pull request?

[ysy2020]

Hi @feiskyer @Jeffwan @losipiuk , any comments on this?

[MaciekPytel]

The code lgtm, but as the number of providers grow we're no longer able to properly maintain them and in particular review code changes to them. We really need an owner for each provider - would you be ok taking that role? If so can you add an OWNER file listing you and / or any other people?

[ysy2020]

The code lgtm, but as the number of providers grow we're no longer able to properly maintain them and in particular review code changes to them. We really need an owner for each provider - would you be ok taking that role? If so can you add an OWNER file listing you and / or any other people?

Thank you for the reply. I'm more than happy to be the owner, but I was wondering whether I'm able to do that since last time I added my name to the OWNER file, the robot added "do-not-merge/invalid-owners-file" label to my pull request #3090. Is there a way to solve that problem?

[Jeffwan]

Overall cloud provider implementation looks good to me. I have not checked detail logic. Major ask is if you can move sdk to go mod extra.

[Jeffwan]

Cluster-autoscaler has its development flow. Do you need to list this separately? If anything is missing, could you contribute back to cluster-autoscaler root level?

[ysy2020]

Thank you for the comment. Yeah you're right about the repetition of the development flow part. The pieces you quoted above have already been mentioned in the root level of cluster autoscaler. The reason I consider it may still be necessary is that the repetition could make the steps of deploying CA on Huawei Cloud CCE more complete, so that people who get this code can follow the exact steps described in the README.md file to make the CA working on CCE.

Please let me know if you still think it unnecessary so I can get rid of that part.

[Jeffwan]

em.. Do you need to check in huawei-cloud-sdk-go? last branch already support go mod, why not use go mod to manage dependencies?

[MaciekPytel]

Actually we encourage that pattern to keep core CA dependencies free of provider-specific ones. The idea is to limit top-level dependencies to core ones, so it's easy to fork and build a CA version for just one provider.
Keeping provider specific dependencies out is one of major motivations discussed in proposals like #3127.

go.mod-extra is mostly meant for bumping version of clients that are already a transitive dependency of kubernetes/kubernetes.

[ysy2020]

Thank you for the comments @Jeffwan @MaciekPytel .

For huawei-cloud-sdk-go, it's not the whole sdk published on "github.com/Huawei/cloud-sdk-go". Only the files that are needed for CA are put in there. Besides, the files that've been used are not the exact same code (some modifications have been made especially for CA) as the original sdk. In this way, even if the code on "github.com/Huawei/cloud-sdk-go" has changed, it has no impact on the CA part.

[MaciekPytel]

Regarding the owner situation - I'm actually not sure how to deal with it, it's the first time this has happened. Let me try to reach out to sig-community and see if there is any guidelines for this.
I guess worst case we can just document that you're the owner and let someone with OWNER permissions rubber-stamp PRs to huaweicloud provider, but I'd like to see if there is a better way first.

[ysy2020]

@MaciekPytel Thank you for being so considerate!

[ysy2020]

@Jeffwan @MaciekPytel

I guess the reason that I cannot add my name to OWNER file is that I'm not a member of kubernetes. I looked at some other PR such as #1536, and found that their pull request was merged first and then the contributor was able to apply for membership of kubernetes and kubernetes-sigs based on their merged contribution. I was wondering whether that's the process of making me the owner of this code (this pull request is merged -> apply for membership of kubernetes -> add my name to OWNER file).

Besides, can I know whether there is anything else that I need to do for this pull request?

[MaciekPytel]

Yeah, I haven't figured out a better workaround. If you could apply for membership, so we can make it an owner that would be ideal. In the meantime feel free to ping me and I can approve any PRs to huaweicloud provider.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [MaciekPytel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ysy2020]

@MaciekPytel

I see. Thank you very much!