From 552f49f0f97ac137e5e6a8ab1ed36267bbdb6836 Mon Sep 17 00:00:00 2001 From: Maksym Fuhol Date: Mon, 23 Sep 2024 13:38:31 +0000 Subject: [PATCH] Register new GCE reservations error message regexp to correctly categorize correctly. --- .../cloudprovider/gce/autoscaling_gce_client.go | 1 + .../cloudprovider/gce/autoscaling_gce_client_test.go | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client.go b/cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client.go index c081c388085a..da18b8f5e436 100644 --- a/cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client.go +++ b/cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client.go @@ -84,6 +84,7 @@ var ( regexp.MustCompile("Reservation (.*) is incorrect for the requested resources"), regexp.MustCompile("Zone does not currently have sufficient capacity for the requested resources"), regexp.MustCompile("Reservation (.*) does not have sufficient capacity for the requested resources."), + regexp.MustCompile("Specified reservation (.*) does not have available resources for the request."), } ) diff --git a/cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client_test.go b/cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client_test.go index 99f3d9603a99..822a46afbd03 100644 --- a/cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client_test.go +++ b/cluster-autoscaler/cloudprovider/gce/autoscaling_gce_client_test.go @@ -201,6 +201,12 @@ func TestErrors(t *testing.T) { expectedErrorCode: "OTHER", expectedErrorClass: cloudprovider.OtherErrorClass, }, + { + errorCodes: []string{"CONDITION_NOT_MET"}, + errorMessage: "Specified reservation 'rsv-name' does not have available resources for the request.", + expectedErrorCode: "INVALID_RESERVATION", + expectedErrorClass: cloudprovider.OtherErrorClass, + }, } for _, tc := range testCases { for _, errorCode := range tc.errorCodes {