Skip to content

Commit 74ceb68

Browse files
benluddyk8s-publishing-bot
authored andcommitted
Export meta internal version scheme for testing.
Codecs is already exported, but in order for tests to construct an alternate CodecFactory for meta's internal version types, they either need to be able to reference the scheme or to construct a parallel scheme, and a parallel scheme construction risks going out of sync with the way the package-scoped scheme object is initialized. Kubernetes-commit: 3e1b6aaf41f2e05146e313d47ec9c288bc554a56
1 parent 840a63c commit 74ceb68

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

pkg/apis/meta/internalversion/scheme/register.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,16 @@ import (
2424
)
2525

2626
// Scheme is the registry for any type that adheres to the meta API spec.
27-
var scheme = runtime.NewScheme()
27+
var Scheme = runtime.NewScheme()
2828

2929
// Codecs provides access to encoding and decoding for the scheme.
30-
var Codecs = serializer.NewCodecFactory(scheme)
30+
var Codecs = serializer.NewCodecFactory(Scheme)
3131

3232
// ParameterCodec handles versioning of objects that are converted to query parameters.
33-
var ParameterCodec = runtime.NewParameterCodec(scheme)
33+
var ParameterCodec = runtime.NewParameterCodec(Scheme)
3434

3535
// Unlike other API groups, meta internal knows about all meta external versions, but keeps
3636
// the logic for conversion private.
3737
func init() {
38-
utilruntime.Must(internalversion.AddToScheme(scheme))
38+
utilruntime.Must(internalversion.AddToScheme(Scheme))
3939
}

pkg/apis/meta/internalversion/scheme/register_test.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ func TestListOptions(t *testing.T) {
3737
Watch: true,
3838
}
3939
out := &metainternalversion.ListOptions{}
40-
if err := scheme.Convert(in, out, nil); err != nil {
40+
if err := Scheme.Convert(in, out, nil); err != nil {
4141
t.Fatal(err)
4242
}
4343
actual := &metav1.ListOptions{}
44-
if err := scheme.Convert(out, actual, nil); err != nil {
44+
if err := Scheme.Convert(out, actual, nil); err != nil {
4545
t.Fatal(err)
4646
}
4747
if !reflect.DeepEqual(in, actual) {
@@ -54,16 +54,16 @@ func TestListOptions(t *testing.T) {
5454
{FieldSelector: "a!!!"},
5555
} {
5656
out = &metainternalversion.ListOptions{}
57-
if err := scheme.Convert(failingObject, out, nil); err == nil {
57+
if err := Scheme.Convert(failingObject, out, nil); err == nil {
5858
t.Errorf("%d: unexpected conversion: %#v", i, out)
5959
}
6060
}
6161

6262
// verify kind registration
63-
if gvks, unversioned, err := scheme.ObjectKinds(in); err != nil || unversioned || gvks[0] != metav1.SchemeGroupVersion.WithKind("ListOptions") {
63+
if gvks, unversioned, err := Scheme.ObjectKinds(in); err != nil || unversioned || gvks[0] != metav1.SchemeGroupVersion.WithKind("ListOptions") {
6464
t.Errorf("unexpected: %v %v %v", gvks[0], unversioned, err)
6565
}
66-
if gvks, unversioned, err := scheme.ObjectKinds(out); err != nil || unversioned || gvks[0] != metainternalversion.SchemeGroupVersion.WithKind("ListOptions") {
66+
if gvks, unversioned, err := Scheme.ObjectKinds(out); err != nil || unversioned || gvks[0] != metainternalversion.SchemeGroupVersion.WithKind("ListOptions") {
6767
t.Errorf("unexpected: %v %v %v", gvks[0], unversioned, err)
6868
}
6969

pkg/apis/meta/internalversion/scheme/roundtrip_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@ import (
2424
)
2525

2626
func TestRoundTrip(t *testing.T) {
27-
roundtrip.RoundTripTestForScheme(t, scheme, fuzzer.Funcs)
27+
roundtrip.RoundTripTestForScheme(t, Scheme, fuzzer.Funcs)
2828
}

0 commit comments

Comments
 (0)