Partitionable model with generated partitions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
thockin
reviewed
Jun 15, 2024
johnbelamaric
force-pushed
the
partitionable-5
branch
from
22d93ff
to
8c008ed
Compare
4 tasks
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this is option 5 in #20, and it build on top of option 4 which is in #31.
It's a little bit crazy. Essentially, instead of enumerating each partition, we use CEL expressions to allow algorithmic creation of the partitions. For example, there are 7 migs with the profile
1g.5gb. They only really differ in their name and which specific memory slices they consume. So, instead of listing all 7, we create a "format" such that iterating over it from 0 to 6 we can instantiate the 7 partitions.This should work, it is more compact even with the current number of memory slices. If there were 100 memory slices, this would make a huge difference compared to #31.