-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dra-evolution: simplify CEL syntax #23
Comments
Based on the discussion in the doc linked in the issue description, I believe for 1.31 we have settle on:
Last point, though: Do we need Now, we are qualifying attribute names with a driver domain. While we did discuss inferring the qualifying domain from the device's driver, this will limit some tricks we probably want to play - see #27 (comment). Given this I think we may want to always require the attribute names to be fully qualified, rather than allowing short names at all. In that case, I see no reason why we shouldn't just use
which is a little more compact. |
My thinking was that we might have CEL expressions on the future for a collection of devices (the constraints), in which case an array called We also have Another reason is that for someone not familiar with DRA, The downside, as you said, is that it is longer. |
Ok, I think this is changeable at implementation time anyway. We should discuss further but not gate the KEP on it. |
As mentioned in kubernetes/enhancements#4709 (comment)), we can also consider abbreviations ( |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
#14 uses
device.attributes[<attribute name>]
anddevice.<type>Attributes[<attribute name>]
, with defaults (nil forattributes
, null value for<type>Attributes
. This works and has been prototyped indra-evolution/pkg/schedule
.There are different ideas how that syntax could be simplified. See #14 (comment) (long discussion!) and https://docs.google.com/document/d/1i0xVx884vsWzVaVb72LtEqjsVILmNkeZimAyz4Bj-m0/edit?usp=sharing (summary of different options).
/assign @johnbelamaric @thockin
The text was updated successfully, but these errors were encountered: