Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No releases since December 2020 #291

Closed
stevehipwell opened this issue Mar 18, 2022 · 9 comments
Closed

No releases since December 2020 #291

stevehipwell opened this issue Mar 18, 2022 · 9 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@stevehipwell
Copy link
Contributor

What happened:
There have been no releases since December 2020 despite there being a number of commits since then. Is this project still maintained and are you expecting to release these changes at any point soon?

What you expected to happen:
n/a

How to reproduce it:
n/a

Anything else we need to know?:
n/a

Environment:
n/a

@mauriciopoppe
Copy link
Member

I've been working on adding Windows support in #270, I'm not sure if @cofyc has plans for a release before this feature is complete but after it's complete I'll work on a new release in 2022Q2

@stevehipwell
Copy link
Contributor Author

@mauriciopoppe @cofyc could you take a look at #289 and follow up on the attached PR to fix your gh-pages issue?

@mauriciopoppe
Copy link
Member

I added /ok-to-test to the test-infra PR, unfortunately I don't have permissions to approve it

@cofyc I saw that there are release instructions in https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/blob/master/RELEASE.md but are missing info about the changes needed in the helm chart, what do you suggest to do for a release, we're trying to have a new release with a newer version of the debian-base image in #295

@mauriciopoppe
Copy link
Member

mauriciopoppe commented Mar 29, 2022

I read the Chart releaser code and it wipes out the existing charts in the branch and does everything from scratch with the latest tag only, this means that across releases only the latest chart will be visible which is a problem.

A few workarounds:

  • Have many copies of the chart by version
charts/
  provisioner/
    v2.4.0/
    v2.5.0/
  • Ask sig-test-infra if they have tools for helm chart publishing Add helm chart repo #199
  • Do what the github action code does on our own in a post submit prow job, we'll have an entrypoint through cloudbuild.yaml and our input is the git tag, through this entrypoint we would
    • Clone the repo at that tag
    • Copy the contents of charts/provisioner to a directory structure that has a version e.g. charts/provisioner/<tag>

@mauriciopoppe
Copy link
Member

mauriciopoppe commented Mar 29, 2022

I misunderstood what the chart releaser Github action does, it's creating a Github release with the chart for the latest tag and hosting a Repository Index yaml file in gh-pages, it looks like we'd need to configure it so that it takes the Changelog from #300, I'm a little bit concerned about it being able to create a git tags automatically from changes in the chart version.

@stevehipwell
Copy link
Contributor Author

@mauriciopoppe chart releaser is the idiomatic way to do this. I'd be happy to look at your CI to check out the pattern?

RE the changelog, you'd need a separate one for the chart as it's a separate release artifact.

I'd suggest having a look at the ExternalDNS repo as a good example of this workflow.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 27, 2022
@andyzhangx
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants