Skip to content

Tweak owners #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2020
Merged

Tweak owners #162

merged 1 commit into from
Jul 9, 2020
+4 −8

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jul 5, 2020 •
edited
Loading

This PR tweaks the OWNERS files by

  • removing names that are no longer active in this or the website community.
  • adding all SIG Docs leads to the approvers list

(edited)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jul 5, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 5, 2020
kbhawkey
kbhawkey reviewed Jul 5, 2020
View reviewed changes
OWNERS Outdated
- kbarnard10
- steveperry-53
# - kbhawkey
# - onlydole
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tengqm , Do you want to remove the pound signs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'kbhawkey', 'onlydole' and 'sftim' are not members of 'kubernetes-sigs', so I was getting "do-not-merge/invalid-owners-file" label for this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Do you know how we become "members"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just dug into the issue. It looks like https://github.com/kubernetes/org/blob/master/config/kubernetes-sigs/org.yaml#L632-L644 is the place to edit it. Will sync with @zacharysarah on the next step.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tengqm Thanks for raising visibility--you are correct, the file in k/org sets admin/write permissions for this repo.

@kbhawkey @onlydole @sftim If I understand correctly, you need to:

  1. Open an issue in k/org to apply for membership in the kubernetes-sigs org. Feel free to assign me and @tengqm for a +1.

  2. Once you're approved as members of kubernetes-sigs, you should be add-able to OWNERS and org.yaml.

Do you need write permissions to generate reference docs?

@tengqm Thanks for tracking down the issue. 🙇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not to generate the docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub issue filed at: kubernetes/org#2006

@tengqm
Tweak owners
74e9efa 
This PR tweaks the OWNERS files by
- removing names that are no longer active in this or the website community.
- adding SIG leads to the approvers list
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 9, 2020
@zacharysarah
Copy link

zacharysarah commented Jul 9, 2020 •
edited
Loading

@nikhita 👋 Can you shed light on the membership situation?

I thought https://github.com/kubernetes/org/pull/2002/files#diff-fec2bf18d37c4aa0eba66d7ebe28f3c6R411 added @sftim as a member of kubernetes-sigs. Did I miss something?

@nikhita
Copy link
Member

nikhita commented Jul 9, 2020

@zacharysarah -- @sftim would need to accept the invite to join k-sigs first. Once they accept the invite and become a member, running /verify-owners will remove the do-not-merge/invalid-owners-file label.

@sftim
Copy link

sftim commented Jul 9, 2020

Invitation received and accepted.

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 9, 2020
@tengqm
Copy link
Contributor Author

tengqm commented Jul 9, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@tengqm: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tengqm
Copy link
Contributor Author

tengqm commented Jul 9, 2020

Ha, forgot that the PR was authored by me. :(

@nikhita
Copy link
Member

nikhita commented Jul 9, 2020

Based on previous PRs and discussion:

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
@nikhita
Copy link
Member

nikhita commented Jul 9, 2020 •
edited
Loading

Dummy comment to check if it triggers tide 🤔

@k8s-ci-robot k8s-ci-robot merged commit 576e15a into kubernetes-sigs:master Jul 9, 2020
@tengqm tengqm deleted the tweak-owners branch December 4, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlydole onlydole onlydole left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@zacharysarah zacharysarah zacharysarah left review comments

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tengqm @zacharysarah @nikhita @sftim @k8s-ci-robot @onlydole @kbhawkey