Add Status to NodeFeature CRD

[ozhuraki]

Closes #1071

[k8s-ci-robot]

Hi @ozhuraki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ozhuraki
Once this PR has been reviewed and has the lgtm label, please assign marquiz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	e4c4364
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/670d25d90aaa890008ab3f52
😎 Deploy Preview	https://deploy-preview-1664--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[TessaIO]

Thanks for your work @ozhuraki. I actually think that we can store other useful information in the worker NFR status, rather than only updated at, like number of features/labels discovered, number of sources that had failures when doing discovery. I don't have concrete use cases here but this is my opinion for now.

[ozhuraki]

@TessaIO @PiotrProkop

Thanks for the input. Updated, please take a look.

[ozhuraki]

@PiotrProkop

Thanks for the review, updated, please take a look.

[ozhuraki]

@PiotrProkop
Thanks, updated.

[TessaIO]

@ozhuraki Are you planning to add some e2e tests for this feature? I think they're important in this use case.

[ozhuraki]

@TessaIO
OK, I will try to add e2e test

[ozhuraki]

@TessaIO

Thanks, added e2e tests, please take a look.

[ozhuraki]

@ArangoGutierrez

Thanks! Updated, please take a look

[ArangoGutierrez]

@ArangoGutierrez

Thanks! Updated, please take a look

@ozhuraki could you rebase, sorry it took me so long, I have been swamped by other stuff

[ozhuraki]

@ArangoGutierrez

Sorry for a delay, missed your coments and thanks for the input.

Converted status to a subresource, please take a look.

[ArangoGutierrez]

/ok-to-test

[ozhuraki]

/retest

[ozhuraki]

/retest

[k8s-ci-robot]

@ozhuraki: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-node-feature-discovery-build-image-cross-generic	e4c4364	link	true	/test pull-node-feature-discovery-build-image-cross-generic

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.