fix: add nodeSelector on Linux to avoid crash on Windows node #634
Conversation
✅ Deploy Preview for kubernetes-sigs-lws canceled.
|
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
| # cpu: 100m | ||
| # memory: 128Mi | ||
| nodeSelector: {} | ||
| nodeSelector: |
There was a problem hiding this comment.
Does kustomize include this selector?
There was a problem hiding this comment.
I have searched in this repo, it does not contain kubernetes.io/os: linux nodeSelector, I think we should use this nodeSelector value by default, and user could specify other values if necessary.
There was a problem hiding this comment.
you can use tolerations (we already have that below), basically setting that by default this doesn't tolerate running on windows machines.
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
5 participants
What type of PR is this?
/kind bug
What this PR does / why we need it
fix: add nodeSelector on Linux to avoid crash on Windows node
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?