Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize create should add config.kubernetes.io/local-config annotation #5746

Open
1 of 2 tasks
ringerc opened this issue Aug 11, 2024 · 1 comment
Open
1 of 2 tasks
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@ringerc
Copy link

ringerc commented Aug 11, 2024

Eschewed features

  • This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

The kustomize docs recommend that kustomization.yaml (and things like transformer configs) should have

metadata:
  annotations:
    config.kubernetes.io/local-config: "true"

but kustomize create does not add this itself.

Why is this needed?

see kustomize help docs-io-annotations

Can you accomplish the motivating task without this feature, and if so, how?

Yes, just patch the created resource with yq, or generate the kustomization manually.

What other solutions have you considered?

Not adding it, it's not (yet) vital

Anything else we should know?

No response

Feature ownership

  • I am interested in contributing this feature myself! 🎉
@ringerc ringerc added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 11, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 11, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants