Allow kustomize CLI to add/set labels with includeSelectors: false

[margeaux-gendron]

Is your feature request related to a problem? Please describe.

Currently, kustomize edit add/set label only supports commonLabels

The introduction of the new label without selectors was intended to fix issues with dynamic labeling changes. However, I don't see a way to dynamically set these labels without selectors with the current CLI.

For example, I cannot dynamically update a version label via CI/CD, due to commonLabels updating selectors which are immutable.

Describe the solution you'd like

Update kustomize edit add/set label to use the new label format with a flag to enable/disable selectors

Describe alternatives you've considered

We are currently using a var in the labels which pulls from a version annotation, and using commonAnnotations instead to set the version dynamically, but vars are planned to be deprecated.

[GraemeF]

I was say this is a bug because running kustomize edit set label version:bar on:

labels:
- includeSelectors: false
  pairs:
    version: foo

produces:

labels:
- includeSelectors: false
  pairs:
    version: foo
commonLabels:
  version: bar

which is of course invalid:

Error: label name 'version' exists in both commonLabels and labels

[koba1t]

Are you want the below functions?

• feat: support edit set label for labels and not only commonLabels #4478
• add: "edit add labels" command adds an option for labels without selector #4486

[margeaux-gendron]

Are you want the below functions?

• feat: support edit set label for labels and not only commonLabels #4478
• add: "edit add labels" command adds an option for labels without selector #4486

Those look to cover what I am asking for, yes.

[natasha41575]

/triage accepted

I will add reviewing the above PRs to my TODO list.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[sudoforge]

@natasha41575 any chance you're able to prioritize those PRs?

i went hunting for why the CLI did not support editing labels (vs commonLabels) today and happened upon this issue. i think this is a fairly necessary feature, and its lack of inclusion when labels were added should be seen (in my opinion) as an oversight, and the current behavior as broken.

if there is anything that either PR needs changed that either author is unwilling or unavailable to change, i will happily take over. this is critical functionality for setting labels with dynamic values.

[AurimasNav]

still looking forward for this to get implemented

[stormqueen1990]

/assign #4486 has since been merged, but I don't think it's been released yet.

[stormqueen1990]

/lifecycle frozen

[stormqueen1990]

My previous comment was incorrect. #4486 is released, I confused that PR for #5682 which allows including labels in templates via edit add label.

[AurimasNav]

It works for adding completely new label, but I don't see how to edit existing one.

labels:
- pairs:
    version: "1"

kustomize edit add label version:2 --without-selector

results in:

labels:
- pairs:
    version: "1"
- pairs:
    version: "2"

kustomize build will apply the bottom label in this case, but that is not ideal seeing how kustomization.yaml will grow with every label update

p.s. neither edit set label nor edit remove label implements --without-selector flag.