Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quantity library and optional types once 1.28 reaches EoL #1986

Open
IrvingMg opened this issue Apr 16, 2024 · 2 comments
Open

Use quantity library and optional types once 1.28 reaches EoL #1986

IrvingMg opened this issue Apr 16, 2024 · 2 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@IrvingMg
Copy link
Contributor

IrvingMg commented Apr 16, 2024

What would you like to be cleaned:

  1. We can remove the validation functions implemented for ClusterQueue in fields with resource.Quantity type.
  2. Additionally, we can shorten some rules that use the macro has() to check an optional field exists.

Why is this needed:

  1. Since Kubernetes 1.29, we can use Kubernetes quantity library to validate fields of resource.Quantity type.
  2. Likewise, we can rewrite some rules to make them more concise using CEL optional types.

Discussion:

@IrvingMg IrvingMg added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 16, 2024
@IrvingMg IrvingMg changed the title Use quantity library once 1.28 reaches EoL Use quantity library and optional types once 1.28 reaches EoL Apr 29, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2024
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

4 participants