-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase ansible timeout to 300 #11354
Conversation
Hi @rptaylor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Thanks @rptaylor It's reasonable, Thanks :-) |
/assign liupeng0518 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liupeng0518, rptaylor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
For large clusters, ansible plays can take a very long time, so failing a play is very expensive.
This increases the ansible timeout so that some nodes that might be slow to respond will still have a chance to save the play.
On small clusters there should not be any disadvantage.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: