-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: specify owner to kube_owner in task of copy cni plugins #10407
fix: specify owner to kube_owner in task of copy cni plugins #10407
Conversation
if not set owner to kube_owner in unarchive module, the owner of /opt/cni/bin will changed to root, which is inconsistent with the previous task.
|
Welcome @NierYYDS! |
Hi @NierYYDS. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thanks @NierYYDS /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NierYYDS Thank you for the PR 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, NierYYDS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…tes-sigs#10407) if not set owner to kube_owner in unarchive module, the owner of /opt/cni/bin will changed to root, which is inconsistent with the previous task.
…tes-sigs#10407) if not set owner to kube_owner in unarchive module, the owner of /opt/cni/bin will changed to root, which is inconsistent with the previous task.
What type of PR is this?
What this PR does / why we need it:
Every time I run
scale.yml
, the following tasks always shows changed.Task of
Copy cni plugins
did not set owner to{{ kube_owner }}
inunarchive
module, so the owner of/opt/cni/bin
will be changed to root, which is inconsistent with the previous task.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: