Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 (ci): Improve GitHub Action to linter samples under testdata #4444

Merged
merged 1 commit into from
Dec 27, 2024
Merged

🌱 (ci): Improve GitHub Action to linter samples under testdata #4444

merged 1 commit into from
Dec 27, 2024

Conversation

camilamacedo86
Copy link
Member

This commit change the action in order to use a matrix to validate all samples under testdata

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 27, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2024
@camilamacedo86
Copy link
Member Author

c/c @mateusoliveira43
Related to the changes proposed at: #4425

@camilamacedo86 camilamacedo86 changed the title 🌱 (ci): Improve GitHub Action to linter simples 🌱 (ci): Improve GitHub Action to linter samples under testdata Dec 27, 2024
mateusoliveira43
mateusoliveira43 reviewed Dec 27, 2024
View reviewed changes
.github/workflows/lint-sample.yml
@@ -11,6 +11,13 @@ on:
jobs:
lint-samples:
runs-on: ubuntu-latest
strategy:
matrix:
folder: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are other test projects in docs folder, right?

Should they be added here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not linting the docs samples for the tutorial
We probably should to do that as well
We need an issue for it. See: #4445

@camilamacedo86
Copy link
Member Author

@mateusoliveira43

Could you LGTM this one?
Then, rebase your PR #4425 with this one?

In the PR #4425 we need add the config + ensure that we call it for Kubebuilder CLI + samples. WDYT?

mateusoliveira43
mateusoliveira43 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@mateusoliveira43 mateusoliveira43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can rebase my PR afterwards :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2024
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2024
@camilamacedo86
(ci): Improve GitHub Action to linter simples
318a6eb 
This commit change the action in order to use a matrix to validate all samples under testdata
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2024
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 88f606f into kubernetes-sigs:master Dec 27, 2024
27 checks passed
@camilamacedo86 camilamacedo86 mentioned this pull request Dec 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusoliveira43 mateusoliveira43 mateusoliveira43 approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @k8s-ci-robot @mateusoliveira43