Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (go/v4): add support to inject conversion webhook for the marker +kubebuilder:scaffold:e2e-webhooks-checks #4407

Merged
merged 1 commit into from
Dec 6, 2024
Merged

✨ (go/v4): add support to inject conversion webhook for the marker +kubebuilder:scaffold:e2e-webhooks-checks #4407

merged 1 commit into from
Dec 6, 2024

Conversation

mateusoliveira43
Copy link
Contributor

Fix #4317

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 2, 2024
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mateusoliveira43. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mateusoliveira43
mateusoliveira43 commented Dec 2, 2024
View reviewed changes
testdata/project-v4/test/e2e/e2e_test.go Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will create a minikube cluster to test if this is right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had trouble testing, because I am without docker in my current machine. Let me see if CI passes

@mateusoliveira43 mateusoliveira43 marked this pull request as ready for review December 5, 2024 12:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
camilamacedo86
camilamacedo86 reviewed Dec 5, 2024
View reviewed changes
pkg/plugins/golang/v4/scaffolds/internal/templates/test/e2e/test.go Outdated
@@ -147,6 +155,22 @@ const validatingWebhookChecksFragment = `It("should have CA injection for valida

`

const conversionWebhookChecksFragment = `It("should have CA injection for conversion webhooks", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is great 🥇
However, since we can have many APIs and in this way many e2e tests to check the injection of each case scenario, should not be nice add in the It something like should have C! injection for the {{ .Resource.Kind }} conversion webhook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add this info

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

camilamacedo86
camilamacedo86 reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2024
camilamacedo86
camilamacedo86 reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mateusoliveira43

It is terrific just a nit.
Here It("should have CA injection for conversion webhooks" I think we should add the kind.

So, ensuring the nit + passing on the tests I think it is great to fly 🚀

@mateusoliveira43
fix: conversion webhook E2E test
9b5ad9c 
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mateusoliveira43 mateusoliveira43 force-pushed the fix/conversion-webhook-e2e-test branch from f334f3a to 9b5ad9c Compare December 6, 2024 18:49
camilamacedo86
camilamacedo86 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@camilamacedo86 camilamacedo86 changed the title 🌱 fix: conversion webhook E2E test ✨ add conversion webhook for e2e tests Dec 6, 2024
@camilamacedo86 camilamacedo86 changed the title ✨ add conversion webhook for e2e tests ✨ add support to inject conversion webhook for e2e tests with the marker +kubebuilder:scaffold:e2e-webhooks-checks Dec 6, 2024
@camilamacedo86 camilamacedo86 changed the title ✨ add support to inject conversion webhook for e2e tests with the marker +kubebuilder:scaffold:e2e-webhooks-checks ✨ (go/v4): add support to inject conversion webhook for the marker +kubebuilder:scaffold:e2e-webhooks-checks Dec 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6c6d6fa into kubernetes-sigs:master Dec 6, 2024
28 checks passed
@camilamacedo86 camilamacedo86 mentioned this pull request Dec 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@mateusoliveira43 @k8s-ci-robot @camilamacedo86