🐛 fix: (helm/v1alpha1): Add missing prefixes in various k8s resources

[monteiro-renato]

Hey 👋
I've added missing prefixes to k8s resources (except for cert-manager ones)
I've added 4 commits so it's easier to review.
I will delete the helm-install.yaml file and squash the commits after the review.

[k8s-ci-robot]

Hi @monteiro-renato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

I understand that you added this to make it easier to review the changes, and it seems like an interesting approach.

However, it appears this was done manually. All the files generated under testdata are created using the shell script found at generate.sh. We cannot manually add or modify content in this directory. Instead, the logic for generating these files needs to be incorporated into the script. Also, the action that calls it will need to have helm installed. We check if the testdata is updated with the PR changes to allow get it merged see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/.github/workflows/testdata.yml

Additionally, if we decide to include this change, we must ensure that the helm-install.yaml file is re-generated when running the Makefile target. This ensures consistency and alignment with the existing build and test automation processes.

[camilamacedo86]

I think this change would need to be in an PR only for that.

[monteiro-renato]

Hi @camilamacedo86,
The helm-install.yaml was indeed created manually but as I mentioned, it was only to make the review easier.
I've deleted it and squashed the commit now 👍.
I do think having a diff of the generated manifests makes it a lot easier to do reviews. It might be something to consider having as part of the normal pipeline.

[camilamacedo86]

Hi @monteiro-renato

Thank you for looking on this. See my comment: #4388 (comment)

I think we need to split this PR, and for we get merged, we should have only one commit, ideally.

[camilamacedo86]

/lgtm
/approve
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, monteiro-renato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment