Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (go/v4): Update actions to use go.mod for Go version management #4385

Merged

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Nov 24, 2024

This commit changes all GitHub Actions to use the go.mod file for specifying the Go version instead of pinning the version directly. This reduces the burden of maintaining the Go version across multiple workflows.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2024
@camilamacedo86 camilamacedo86 changed the title ✨ Use go.mod to define the Go version in the actions ✨ (go/v4): Update actions to use go.mod for Go version management Nov 24, 2024
@camilamacedo86 camilamacedo86 changed the title ✨ (go/v4): Update actions to use go.mod for Go version management WIP ✨ (go/v4): Update actions to use go.mod for Go version management Nov 24, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2024
@camilamacedo86 camilamacedo86 changed the title WIP ✨ (go/v4): Update actions to use go.mod for Go version management ✨ (go/v4): Update actions to use go.mod for Go version management Nov 24, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2024
@camilamacedo86 camilamacedo86 force-pushed the enhance-go-version branch 3 times, most recently from 7a2c2c3 to 697678b Compare November 24, 2024 15:24
@sxd
Copy link

sxd commented Nov 24, 2024

LGTM no other appearance of the go-version specific field

This commit changes all GitHub Actions to use the go.mod file for specifying the Go version instead of pinning the version directly. This reduces the burden of maintaining the Go version across multiple workflows.
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit c3b2eb9 into kubernetes-sigs:master Nov 24, 2024
26 checks passed
@camilamacedo86 camilamacedo86 deleted the enhance-go-version branch November 24, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants