🐛 : (go/v4) fixes based on golangci-lint run -v

[monteiro-renato]

Fixes: #4376

[k8s-ci-robot]

Hi @monteiro-renato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[monteiro-renato]

I also tried bumping the version of golangci-lint to 1.62 but the lint action started breaking with:

  Error: testdata/project-v4/test/utils/utils.go:40:21: undefined: GinkgoWriter (typecheck)
  	_, _ = fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)

[camilamacedo86]

/lgtm
/ok-to-test

[camilamacedo86]

THANK you a lot 🥇
You are been a rock star 🚀

By the way, 🌱 we just use when it is something that does not change anything for end users

[camilamacedo86]

/lgtm
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, monteiro-renato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[monteiro-renato]

This seems to be mergeable but I think I found another bug.
The e2e tests on the test setup I created based on your commands are failing due to the container failing to start.

NAME                                          READY   STATUS              RESTARTS   AGE
kb-test-controller-manager-6fd7dfb975-2dqkq   0/1     ContainerCreating   0          2m7s

Describing the pod displays:

Warning  FailedMount  29s (x9 over 2m45s)  kubelet            MountVolume.SetUp failed for volume "cert" : secret "webhook-server-cert" not found

Looks like there's further troubleshooting to do.

[monteiro-renato]

Might not actually be a bug. Might be some missing manual configs (which may or may not be documented in the book, I haven't checked).

But yea, simply running those three commands you posted in the issue and pushing the code to Github doesn't seem to be enough to make the e2e tests happy.

Edit: I'm done for the day. I might take a look at the docs during the weekend if I find the time.