Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (helm/v1alpha1): add GitHub action to make easier validate the chart generate #4377

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Nov 22, 2024

Add action will help us and users validate the chart
See that it works: https://github.com/camilamacedo86/test-project/actions/runs/11971426907/job/33376226272

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2024
@camilamacedo86
Copy link
Member Author

Hi @monteiro-renato

I am moving forward with this one, but if you want to address any changes or improvements please feel free
It helps us to find issues.
For example, I noticed some issues related to the Prometheus integration.
I will open an issue for that.
There is probably something silly we are missing in the name.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit c35cd8f into kubernetes-sigs:master Nov 22, 2024
23 checks passed
@monteiro-renato
Copy link
Contributor

Hi @camilamacedo86,
Should we add a step before "Install Helm chart for project" with a step that prints the final manifest?
i.e. something along the lines of helm template --namespace=qualquer dist/chart.

That's basically what I was doing locally to detect problems with the chart by comparing the generated helm manifest with the kustomize version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants