✨ feat: (helm/v1alpha1): Allow extra pod labels to be configured

[monteiro-renato]

The use case I have in mind is for example Azure WI configuration.

[k8s-ci-robot]

Hi @monteiro-renato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

See:

kubebuilder/testdata/project-v4/config/default/kustomization.yaml

Lines 11 to 15 in d40e7f2

	# Labels to add to all resources and selectors.
	#labels:
	#- includeSelectors: true
	# pairs:
	# someName: someValue

I think we need to replicate the behaviour
We need to check this file
and ensure that we do in the chart the same what we would to do with kustomize

[monteiro-renato]

I think the use-case is a bit different.
This PR is an attempt to have something similar to:

# This patch adds an Azure Workload Identity required label to the pod
- op: add
  path: /spec/template/metadata/labels
  value:
    azure.workload.identity/use: "true"

---

Since you mentioned that file however, I did notice what is likely an unintended behavior while testing kubebuilder with kustomize. If you run:

cd /tmp && \
mkdir kbtestdir && \
cd kbtestdir && \
git init && \
kubebuilder init --domain tutorial.kubebuilder.io --repo tutorial.kubebuilder.io/project && \
make build-installer && \
git add . && \
kubebuilder create api --group batch --version v1 --kind CronJob --controller --resource  && \
git add . && \
make build-installer

and then check the changes, you will notice that the ClusterRole in the config/rbac/role.yaml file had it's labels removed. The generated CRD in the config/crd/bases/ is also generated without labels. For this use case I think it makes sense to use kustomize to make sure even the generated resources get the labels added.

[camilamacedo86]

But above the option to add labels is commented. (

kubebuilder/testdata/project-v4/config/default/kustomization.yaml

Lines 11 to 15 in d40e7f2

	# Labels to add to all resources and selectors.
	#labels:
	#- includeSelectors: true
	# pairs:
	# someName: someValue

)

I think you should not do the patch.
You should use the option in the customization, right?
So, it would not add new labels to the result of build-installer.
I am not sure if I follow, sorry.

But if you see that is a bug/or you would expected another behaviour
Can you please open an issue with the steps, what you have seen and what you expected?
So, we can fix that as well.

[camilamacedo86]

Hi @monteiro-renato

Lets move forward with this one.
It is an alpha version anyway we can break things if we need after
But we need to have an issue to see how we work with

https://github.com/kubernetes-sigs/kubebuilder/pull/4373/files#r1853825165

[camilamacedo86]

/lgtm
/approved
/ok-to-test

[camilamacedo86]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, monteiro-renato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment