🐛 fix: (helm/v1alpha1) add missing name prefix and namespace to leader-election-role and leader-election-rolebinding

[monteiro-renato]

I'm not sure this is the best approach but since there are already some hardcoded values in there I suppose it's not a terrible idea either.

The Role and RoleBinding do not have a namespace associated with them when the project is inited. I didn't actually try to deploy this but I believe this would actually fail to apply as is (without the namepace on the Role and RoleBinding - src).

I added the expected value that a later instruction is expecting.

There are a few other resources that do not have the prefix either. I can open other PRs to address those individually.

[k8s-ci-robot]

Hi @monteiro-renato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[monteiro-renato]

Hey 👋,
Apologies if I'm opening too many PRs and it's hard to keep track of what's going on.

I basically noticed these small inconsistencies when I compared the generated manifests via Kustomize and Helm side by side .
Check the install.yaml of this one as an example.

[camilamacedo86]

Hi @monteiro-renato

Really thank you to catcher this one 🥇
We can look in the dist/install.yaml to validate how kustomize
generate the staff: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4-with-plugins/dist/install.yaml

You are right we should change the name
I hope has no other places.
I think for now is OK we change in the code as you did
We might find better ways in the future

Again thank you a lot for all hard work 🥇

/lgtm
/approve
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, monteiro-renato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment