🐛 (go/v4): Fix path configuration for webhook markers generated for core types with non-"core" group values

[damsien]

This PR is related to this issue: #4300. I added one more check on resources that belongs to a group even if they are considered to be part of the core type.

So kubebuilder create webhook --group apps --version v1 --kind Deployment --programmatic-validation will generate:

// +kubebuilder:webhook:path=/validate-apps-v1-deployment,...

And kubebuilder create webhook --group core --version v1 --kind Pod --programmatic-validation will generate:

// +kubebuilder:webhook:path=/validate--v1-pod,...

as expected.

We already discussed about the double dash -- for the core group in the linked issue.

[k8s-ci-robot]

Hi @damsien. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Hi @damsien

Thank you for push the fix.
That is great 🥇

Can you please run make generate ?

We need to run this command for all prs, so that it will update the samples under testdata and under the docs with your changes.

Also, please ensure that those changes are committed and squashed.
We need to have one commit per PR.

[damsien]

I already ran make generate but it did not change anything in the testdata and the books folders since it is a very specific fix that create the annotation in very particular usecase.

I try again to make it works well

[camilamacedo86]

/ok-to-test

[camilamacedo86]

Hi @damsien

See that we have the script to generate all that is under testdata: https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/testdata/generate.sh

Then, see that we test things out by scaffolding an webhook for Core Type here:

• https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/testdata/generate.sh#L89-L91
• https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/testdata/generate.sh#L61

However, both are using Group "core" and Kind Pod
Can you add a new scaffold to generate a webhook for your case scenario? Group apps Kind Deployments so that we can check its result?

Please, add the command to generate:

• For Multigroup (https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/testdata/generate.sh#L89-L91) only (--programmatic-validation): kb create webhook --group apps --version v1 --kind Deployment --defaulting
• And for project-v4 both ( https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/testdata/generate.sh#L61 ) : kb create webhook --group apps --version v1 --kind Deployment --programmatic-validation --defaulting

[damsien]

Done ✔️

[camilamacedo86]

/approved
/lgtm

Thank you a lot for your contribution 🥇

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, damsien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment