✨ (go/v4): Add Hub and Spoke for conversion webhooks #4254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
camilamacedo86
force-pushed
the
huc-spoke
branch
2 times, most recently
from
7027ba2 to
0941851
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
huc-spoke
branch
2 times, most recently
from
efe33fd to
7216ea6
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
huc-spoke
branch
8 times, most recently
from
8b2b36d to
233645d
Compare
camilamacedo86
changed the title
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Nov 2, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Nov 2, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
force-pushed
the
huc-spoke
branch
2 times, most recently
from
501e28c to
cc242e6
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
commented
Nov 10, 2024
camilamacedo86
force-pushed
the
huc-spoke
branch
2 times, most recently
from
dd213e6 to
be62108
Compare
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
huc-spoke
branch
2 times, most recently
from
e039767 to
9a11598
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
camilamacedo86
force-pushed
the
huc-spoke
branch
2 times, most recently
from
c047d72 to
2454643
Compare
This commit introduces support for the conversion webhook by adding a hub and spoke implementation.
camilamacedo86
force-pushed
the
huc-spoke
branch
from
2454643 to
15f17cf
Compare
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Nov 24, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
varshaprasad96
approved these changes
Nov 30, 2024
There was a problem hiding this comment.
Thanks @camilamacedo86! Tested this out, and this looks good!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
camilamacedo86
merged commit 781e93f
into
kubernetes-sigs:master
24 of 26 checks passed
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Dec 1, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Dec 1, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Dec 1, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Dec 1, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Dec 1, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for scaffolding a conversion webhook with a hub-and-spoke model in Kubebuilder Go plugin (v4). The feature allows defining one hub version with one or many spoke versions for seamless conversion between CustomResourceDefinition (CRD) API versions.
How It Will Work:
Users can:
OR
Closes; #2589