Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (go/v4): Enable seccompProfile.type: RuntimeDefault by default in scaffolded projects #4251

Merged
merged 1 commit into from
Nov 9, 2024
Merged

✨ (go/v4): Enable seccompProfile.type: RuntimeDefault by default in scaffolded projects #4251

merged 1 commit into from
Nov 9, 2024

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Oct 30, 2024 •
edited
Loading

  • Removed the comment about seccompProfile as type: RuntimeDefault is now set by default.
  • Updated to reflect that Kubebuilder only tests and supports the latest three Kubernetes releases.
  • Given that we’re currently using Kubernetes 1.31, there’s no longer a reason to keep this line commented, ensuring projects adhere to restricted Pod Security Standards by default.
  • Either OCP 4.10 is in EOL already: https://endoflife.date/red-hat-openshift

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2024
@camilamacedo86 camilamacedo86 changed the title ✨ Enable seccompProfile.type: RuntimeDefault by default in scaffolded projects ✨ (go/v4): Enable seccompProfile.type: RuntimeDefault by default in scaffolded projects Nov 2, 2024
@camilamacedo86
Copy link
Member Author

/hold

Just to not merge before we do a patch release; #4284

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 2, 2024
@camilamacedo86 camilamacedo86 force-pushed the remove-comment-line-ensure-all-restricted branch from 921ba04 to 7cd8419 Compare November 9, 2024 10:21
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2024
@camilamacedo86 camilamacedo86 force-pushed the remove-comment-line-ensure-all-restricted branch from 7cd8419 to 90f33f0 Compare November 9, 2024 12:50
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2024
camilamacedo86
camilamacedo86 commented Nov 9, 2024
View reviewed changes
Copy link
Member Author

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

We can get it merged now.
Since it is to small I will not make nobody waste time on reviews here.
We have big fishes to fry.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2024
@camilamacedo86
Enable seccompProfile.type: RuntimeDefault by default in scaffolded…
75ac2fb 
… projects

- Removed the comment about `seccompProfile` as `type: RuntimeDefault` is now set by default.
- Updated to reflect that Kubebuilder only tests and supports the latest three Kubernetes releases.
- Given that we’re currently using Kubernetes 1.31, there’s no longer a reason to keep this line commented, ensuring projects adhere to `restricted` Pod Security Standards by default.
@camilamacedo86 camilamacedo86 force-pushed the remove-comment-line-ensure-all-restricted branch from 90f33f0 to 75ac2fb Compare November 9, 2024 13:01
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2024
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0df6220 into kubernetes-sigs:master Nov 9, 2024
24 checks passed
@camilamacedo86 camilamacedo86 deleted the remove-comment-line-ensure-all-restricted branch November 9, 2024 14:01
@camilamacedo86 camilamacedo86 mentioned this pull request Dec 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camilamacedo86 @k8s-ci-robot