📖 Correct misleading information in production note for metrics config #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
@varshaprasad96 and @Kavinjsir could you please give a hand on this one? |
camilamacedo86
changed the title
grzesuav
reviewed
Oct 30, 2024
| environments as they do not offer the same level of trust and security as certificates issued by a trusted | ||
| Certificate Authority (CA). | ||
| The default scaffold in `cmd/main.go` uses a **controller-runtime feature** | ||
| to generate a certificate for securing the metrics server. While convenient |
There was a problem hiding this comment.
...to generate a self-signed certificate...
There was a problem hiding this comment.
I believe self-signed part is worth to keep
grzesuav
approved these changes
Oct 30, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, grzesuav, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLSOpts info was not accurate. Simplified the information to ensure accuracy in production setup notes and fixed grammar issues for readability and precision.