-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ upgrade golang version to 1.18 #2561
Conversation
Welcome @AlmogBaku! |
Hi @AlmogBaku. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AlmogBaku The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @AvineshTripathi |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
/ok-to-test |
--- Kubebuilder's master branch is introducing support for Golang 1.18 kubernetes-sigs/kubebuilder#2561
This PR to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits for we are able to get this one merged
a) Could you please update the PR title for :sparkles: upgrade Go version to 1.18 (adds supports to go 1.18)
- Done
b) ensure that all plugins use golang 1.18 ( we are not updating go/v2 see (#2571
c) Could you revert the min go version forced by the CLI and ensure the same values for go/v2?
d) By the latest could we update the quick start after deep thought, I think we do not need to have the go version for each release and we should keep the info regards the latest one only, so go version >= 1.18 wdyt? Then we close with this PR this one #2548 too? We do not track in the docs the info/changes for each release made so that makes no sense we have the go version per release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, see that we need to do a little bit more here to get this one merged
Could you please try to address the commands/suggestions?
IF you have doubts feel free to ping me in the slack.
d9580f6
to
e6a7b29
Compare
Hey all, Please comment here on your notes, and let's take a call what are the next action items. |
3a5358b
to
b43e2ea
Compare
Hi all, |
@AlmogBaku: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was updated to clarify all that was discussed and what we will need to do to achieve this goal. See: #2561
Thank you for working on that and helping us to identify the needs.
Go changed the results of the `ReadBuildInfo` in go 1.18. Now it always returns information also for modules For more information on the use-case see kubernetes-sigs/kubebuilder#2561 (comment)
I think we will need to discuss few points but I will not block the pr
Again, thank you for your terrific work 🥇 and help us identify what we will need to do to accomplish this goal. a) split the changes between CLI and go/v3 ( scaffold ) In this way, wdyt about we close this one and then work on the new PRs? /hold |
@AlmogBaku: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As of today, Kube-builder does not support go 1.18: kubernetes-sigs/kubebuilder#2561. Also, note that installing executables with go get is deprecated in go1.18 (xref:https://go.dev/doc/go-get-install-deprecation). Co-authored-by: Francesco Romani <fromani@redhat.com> Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
--- Kubebuilder's master branch is introducing support for Golang 1.18 kubernetes-sigs/kubebuilder#2561
--- Kubebuilder's master branch is introducing support for Golang 1.18 kubernetes-sigs/kubebuilder#2561
Description:
This PR introduces Golang 1.18 support for Kubebuilder.
It makes Kubebuilder use go1.18 for both compiling the CLI and the scaffolded code.
For more information about this, see issue #2559
Motivation:
Closes #2559