Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(helm/v1alpha): Not expose webhooks data #4382

Open
camilamacedo86 opened this issue Nov 22, 2024 · 1 comment · May be fixed by #4451
Open

(helm/v1alpha): Not expose webhooks data #4382

camilamacedo86 opened this issue Nov 22, 2024 · 1 comment · May be fixed by #4451
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-blocker
Milestone
helm

Comments

@camilamacedo86
Copy link
Member

camilamacedo86 commented Nov 22, 2024 •
edited
Loading

What do you want to happen?

Allowing users to modify webhook configuration values directly is not ideal. Currently, generating webhooks relies on Kubebuilder markers, which creates challenges in Helm chart generation.

The goal is to enable webhook chart generation with minimal exposure in values.yaml, ideally limiting it to webhook.enable: true, as done for other options. Exposing all data does not make sense when we do not want people to make changes to it.

Additionally, the current approach requires using --force to regenerate webhooks, which overwrites any value customisations.yaml, leading to a potential loss of configurations.

Extra Labels

No response
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 22, 2024
@camilamacedo86
Copy link
Member Author

JFY: @monteiro-renato

@camilamacedo86 camilamacedo86 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-blocker and removed release-blocker labels Nov 24, 2024
@camilamacedo86 camilamacedo86 modified the milestones: helm, 2025 Nov 25, 2024
@camilamacedo86 camilamacedo86 mentioned this issue Dec 14, 2024
Open
@camilamacedo86 camilamacedo86 linked a pull request Dec 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-blocker
Projects
None yet
Milestone
helm
1 participant
@camilamacedo86