load add image-load, support podman load #3109

helen-frank · 2023-02-23T09:43:29Z

/kind feature

Kind load add command image-load, extension supports podman load

k8s-ci-robot · 2023-02-23T09:43:37Z

Welcome @helen-frank!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-02-23T09:43:38Z

Hi @helen-frank. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: helen <haitao.zhang@daocloud.io>

aojea · 2023-02-23T10:19:23Z

how is this different than current one that is not working in podman because of podman limitations to load images?

#3105

helen-frank · 2023-02-23T10:38:31Z

how is this different than current one that is not working in podman because of podman limitations to load images?

#3105

My current implementation is feasible, I have tested it, and this problem is also found by wanting to use kwok on the kind-podman

podman pull docker.io/kindest/node:v1.25.0                                                                                                                                                                     ─╯
Trying to pull docker.io/kindest/node:v1.25.0...
Getting image source signatures
Copying blob 9602ae1e967a done
Copying blob 405bac4f49ab done
Copying config d3da246e12 done
Writing manifest to image destination
Storing signatures
d3da246e125a0644c137ffd5ecaea7658d4875581a82891b955b319aa6341d11
╭─   ~                                                                                                                                                            took  40s with root@10-29-16-89 at  10:32:24 ─╮
╰─❯ podman version                                                                                                                                                                                                 ─╯
Version:      3.4.4
API Version:  3.4.4
Go Version:   go1.17.3
Built:        Thu Jan  1 00:00:00 1970
OS/Arch:      linux/amd64
╭─   ~                                                                                                                                                                       with root@10-29-16-89 at  10:32:29 ─╮
╰─❯ podman ps                                                                                                                                                                                                      ─╯
CONTAINER ID  IMAGE                                                                                           COMMAND     CREATED         STATUS             PORTS                        NAMES
508321ce6a0f  docker.io/kindest/node@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1              7 days ago      Up 2 days ago                                   multi-node-worker2
49270a353240  docker.io/kindest/node@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1              7 days ago      Up 2 days ago                                   multi-node-worker
c9f635cd7edd  docker.io/kindest/node@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1              7 days ago      Up 2 days ago      10.29.16.89:41201->6443/tcp  multi-node-control-plane
a67d9f6f893b  docker.io/kindest/node:v1.26.0                                                                              11 minutes ago  Up 11 minutes ago  0.0.0.0:39493->6443/tcp      kwok-m1-control-plane
╭─   ~                                                                                                                                                                       with root@10-29-16-89 at  10:32:41 ─╮
╰─❯ kind load image-load --name kwok-m1 docker.io/kindest/node:v1.25.0                                                                                                                                             ─╯
enabling experimental podman provider
Image: "docker.io/kindest/node:v1.25.0" with ID "d3da246e125a0644c137ffd5ecaea7658d4875581a82891b955b319aa6341d11" not yet present on node "kwok-m1-control-plane", loading...
╭─   ~                                                                                                                                                            took  50s with root@10-29-16-89 at  10:33:57 ─╮
╰─❯ podman exec a67d9f6f893b crictl images ls | grep "docker.io/kindest/node"                                                                                                                                      ─╯
docker.io/kindest/node                     v1.25.0              d3da246e125a0       875MB

aojea · 2023-02-23T10:44:24Z

yeah, I was curious what is the difference with current docker-image command that makes this works and the other not 😄

helen-frank · 2023-02-23T11:00:33Z

yeah, I was curious what is the difference with current docker-image command that makes this works and the other not 😄

In fact, the difference between image-load and docker-image is whether the runtime is variable or not

The naming of docker-image prevents me from writing this logic to the boot

It's hard to predict how much of an impact image-load would have if it replaced docker-image

So I chose to create a new command, preferably using image-load and removing docker-image if I could.

aojea · 2023-02-23T11:25:07Z

In fact, the difference between image-load and docker-image is whether the runtime is variable or not

do you mean that podman has changed something and now the docker-imagecommand works with podman too?

if you do kind load docker-image --name kwok-m1 docker.io/kindest/node:v1.25.0 does it work too?
we have a bug open for a long time because it didn't worked with podman

aojea · 2023-02-23T11:54:29Z

pkg/cmd/kind/load/image-load/image-load.go

+		if _, err := osexec.LookPath("podman"); err != nil {
+			return "", err
+		}
+		return "podman", nil


is this the difference?

because this was not working before #2760

I tried to use docker-image in the form of soft links, and I succeeded.

❯ ln -s /usr/bin/podman /usr/bin/docker ❯ kind load docker-image --name kwok-m1 docker.io/kindest/node:v1.24.0 enabling experimental podman provider Image: "docker.io/kindest/node:v1.24.0" with ID "a7d31d743aca47d4cdb00d6f61ba58b2423a1ead57dffa234f8d4f402f0a049d" not yet present on node "kwok-m1-control-plane", loading... ❯ podman exec a67d9f6f893b crictl images ls | grep "docker.io/kindest/node" docker.io/kindest/node v1.24.0 a7d31d743aca4 915MB docker.io/kindest/node v1.25.0 d3da246e125a0 875MB

❯ cat /etc/os-release PRETTY_NAME="Ubuntu 22.04.2 LTS" NAME="Ubuntu" VERSION_ID="22.04" VERSION="22.04.2 LTS (Jammy Jellyfish)" VERSION_CODENAME=jammy ID=ubuntu ID_LIKE=debian HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" UBUNTU_CODENAME=jammy

is this the difference?

Yeah, simple and effective, I didn't find podman has the problem of preventing ctr from writing.

something seems to have changed in podman or my memory is confused 😄

@BenTheElder it seems we can have the common load-image with no effort

helen-frank · 2023-03-04T14:43:38Z

@aojea Can you give me an ok-to-test label?
Or can we continue to push.

aojea · 2023-03-04T18:05:50Z

@aojea Can you give me an ok-to-test label?

/ok-to-test

helen-frank · 2023-03-06T01:26:31Z

/retest

helen-frank · 2023-03-06T14:11:37Z

Can we continue?😀 @aojea @danderson @BenTheElder
First of all, it can be confirmed that image-load is already available on my podman environment.
What needs to be pushed forward in the future is which plan to adopt.

use image-load
use image-load and delete docker-image
Code ability to be combined into docker-image (not recommended, will lead to misunderstanding)

BenTheElder · 2023-03-06T20:31:23Z

erm, Please see: #2038, we should be discussing approaches to new features in the feature issues, per our contributing docs. https://kind.sigs.k8s.io/docs/contributing/getting-started/#4-reaching-out

I'm sorry, but all hands on deck with Keeping the Kubernetes project funded right now (See SIG K8s Infra).
I will not be spending much time reviewing kind features until we have a plan to sustain the Kubernetes organization.

The next thing up for the kind project is a release with all the existing bug fixes, when @aojea gets time.

We need to get the API right before introducing a new command, people will begin depending on it immediately.

If podman is actually working drop-in compatible here and we don't want to do all of #2038, we can design a third command (see the existing proposal) and give it a better name. kind load image-load is a confusing name.

k8s-ci-robot · 2023-05-16T05:22:22Z

@mimani68: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-05-16T05:22:25Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: helen-frank, mimani68
Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stmcginnis

It looks like podman does have the necessary commands now. So from what I can tell, this should be good just swapping out docker for podman when needed.

If we have a general common command for this, should we add a note to load docker-image that it is deprecated and this new command should be used instead?

BenTheElder · 2024-06-20T22:06:09Z

If we have a general common command for this, should we add a note to load docker-image that it is deprecated and this new command should be used instead?

We probably shouldn't deprecate docker-image, it's more specific and widely used.

We really need a discussed approach (preferably in a tracking issue) that also considers nerdctl / other runtimes.

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2023

k8s-ci-robot requested review from aojea and neolit123 February 23, 2023 09:43

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 23, 2023

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2023

load add image-load, support podman load

0902e2b

Signed-off-by: helen <haitao.zhang@daocloud.io>

helen-frank force-pushed the feature/loadAddPodman branch from 7607f6b to 0902e2b Compare February 23, 2023 09:44

helen-frank mentioned this pull request Feb 23, 2023

[WIP] runtime use kind: kind support podman kubernetes-sigs/kwok#323

Closed

aojea reviewed Feb 23, 2023

View reviewed changes

BenTheElder added this to the v0.19.0 milestone Mar 2, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2023

mimani68 approved these changes May 16, 2023

View reviewed changes

BenTheElder removed this from the v0.19.0 milestone May 17, 2023

stmcginnis reviewed May 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

load add image-load, support podman load #3109

load add image-load, support podman load #3109

helen-frank commented Feb 23, 2023

k8s-ci-robot commented Feb 23, 2023

k8s-ci-robot commented Feb 23, 2023

aojea commented Feb 23, 2023

helen-frank commented Feb 23, 2023

aojea commented Feb 23, 2023

helen-frank commented Feb 23, 2023 •

edited

Loading

aojea commented Feb 23, 2023 •

edited

Loading

aojea Feb 23, 2023

aojea Feb 23, 2023

helen-frank Feb 23, 2023

helen-frank Feb 23, 2023

helen-frank Feb 23, 2023

aojea Feb 23, 2023

helen-frank commented Mar 4, 2023 •

edited

Loading

aojea commented Mar 4, 2023

helen-frank commented Mar 6, 2023

helen-frank commented Mar 6, 2023

BenTheElder commented Mar 6, 2023 •

edited

Loading

k8s-ci-robot commented May 16, 2023

k8s-ci-robot commented May 16, 2023

stmcginnis left a comment

BenTheElder commented Jun 20, 2024

load add image-load, support podman load #3109

Are you sure you want to change the base?

load add image-load, support podman load #3109

Conversation

helen-frank commented Feb 23, 2023

k8s-ci-robot commented Feb 23, 2023

k8s-ci-robot commented Feb 23, 2023

aojea commented Feb 23, 2023

helen-frank commented Feb 23, 2023

aojea commented Feb 23, 2023

helen-frank commented Feb 23, 2023 • edited Loading

aojea commented Feb 23, 2023 • edited Loading

aojea Feb 23, 2023

Choose a reason for hiding this comment

aojea Feb 23, 2023

Choose a reason for hiding this comment

helen-frank Feb 23, 2023

Choose a reason for hiding this comment

helen-frank Feb 23, 2023

Choose a reason for hiding this comment

helen-frank Feb 23, 2023

Choose a reason for hiding this comment

aojea Feb 23, 2023

Choose a reason for hiding this comment

helen-frank commented Mar 4, 2023 • edited Loading

aojea commented Mar 4, 2023

helen-frank commented Mar 6, 2023

helen-frank commented Mar 6, 2023

BenTheElder commented Mar 6, 2023 • edited Loading

k8s-ci-robot commented May 16, 2023

k8s-ci-robot commented May 16, 2023

stmcginnis left a comment

Choose a reason for hiding this comment

BenTheElder commented Jun 20, 2024

helen-frank commented Feb 23, 2023 •

edited

Loading

aojea commented Feb 23, 2023 •

edited

Loading

helen-frank commented Mar 4, 2023 •

edited

Loading

BenTheElder commented Mar 6, 2023 •

edited

Loading