Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set System Reserved as percentage #1595

Open
rrmarq opened this issue Aug 22, 2024 · 2 comments
Open

Set System Reserved as percentage #1595

rrmarq opened this issue Aug 22, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@rrmarq
Copy link

rrmarq commented Aug 22, 2024

Description

What problem are you trying to solve?
Dynamic overhead calculation for O.D resources reservation.

How important is this feature to you?
After having some problems with instances running out of capacity until kubelet get killed by the os, letting them with a “zombie node”, we started to reserve resources for the O.S calculating a percentage based on the instance size and setting the value in the userData.
Setting the value in the userData might make Karpenter calculate the instances resources wrongly ending up and bad instance selections.
An alternative is setting this value in nodepool.spec.template.spec.kubelet, however, using this options it is only possible with static values.
As we have nodepools with different sizes, we would like to set the value overhead as percentage, without having to do it via userData.

@rrmarq rrmarq added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 22, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 22, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bnu0
Copy link

bnu0 commented Aug 31, 2024

We'd love to be able to make these a percentage. We use reserved memory to ensure sufficient burst capacity across our fleet, and achieve higher density by keeping requests accurate. The static nature of these settings means we cannot allocate instances fully dynamically, as the values do not make sense for significantly larger or smaller nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants