Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move exclusive API to annotation #97

Closed
ahg-g opened this issue May 1, 2023 · 1 comment · Fixed by #98
Closed

Move exclusive API to annotation #97

ahg-g opened this issue May 1, 2023 · 1 comment · Fixed by #98
Assignees
@danielvegamyhre

Comments

@ahg-g
Copy link
Contributor

ahg-g commented May 1, 2023

It is not yet clear if the current API (#75) is the one we will eventually promote, given this uncertainty and to make the alpha to beta upgrade process easy, I suggest we move this API to be supported as an annotation while we figure out what the concrete API will actually look like.

metadata.annotations[alpha.jobset.sigs.k8s.io/exclusive] = <topologydomain>
@danielvegamyhre
Copy link
Contributor

/assign

@danielvegamyhre danielvegamyhre mentioned this issue May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielvegamyhre danielvegamyhre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move exclusiveness to annotation danielvegamyhre/jobset
2 participants
@ahg-g @danielvegamyhre