You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are trying to build images in a different infrastructure that requires vendoring the dependencies.
I can attest that a lot of build tooling for FIPS really wants vendored dependencies. I can ask around to see if this is a requirement for FIPS or just a nice to have.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Activity
ahg-g commentedon Jan 25, 2025
I am not sure if this is needed, what we currently have works and the build time is not a major issue here.
ahg-g commentedon Jan 25, 2025
I just don't want to unnecessarily introduce new sources of errors/problems
kannon92 commentedon Jan 25, 2025
I'm unclear on the motivation for Kueue.
From the kueue issue,
I can attest that a lot of build tooling for FIPS really wants vendored dependencies. I can ask around to see if this is a requirement for FIPS or just a nice to have.
andreyvelich commentedon Jan 26, 2025
I agree with @ahg-g, and I added my thoughts here: #764 (comment).
kannon92 commentedon Feb 7, 2025
Post from aldo: #764 (comment)
In openshift, we are going to vendor this repo in our fork due to hermetic build requirements.
We can close this if we feel that this is not worth putting in upstream. We still have to do it on our downstream builds but it is what it is.
ahg-g commentedon Feb 7, 2025
+1 to not invest in this now
kannon92 commentedon Feb 7, 2025
/close
k8s-ci-robot commentedon Feb 7, 2025
@kannon92: Closing this issue.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.