Skip to content

Vendor dependencies #763

Closed
Closed
@kannon92

Description

I notice that Kueue vendors their dependencies. They found that it helped speed up the build system.

I'd like to propose that we vendor also so that we are consistent with kueue and we can gain some benefits of builds.

kubernetes-sigs/kueue#2374

Activity

ahg-g

ahg-g commented on Jan 25, 2025

@ahg-g
Contributor

I am not sure if this is needed, what we currently have works and the build time is not a major issue here.

ahg-g

ahg-g commented on Jan 25, 2025

@ahg-g
Contributor

I just don't want to unnecessarily introduce new sources of errors/problems

kannon92

kannon92 commented on Jan 25, 2025

@kannon92
ContributorAuthor

I'm unclear on the motivation for Kueue.

From the kueue issue,

We are trying to build images in a different infrastructure that requires vendoring the dependencies.

I can attest that a lot of build tooling for FIPS really wants vendored dependencies. I can ask around to see if this is a requirement for FIPS or just a nice to have.

andreyvelich

andreyvelich commented on Jan 26, 2025

@andreyvelich
Contributor

I agree with @ahg-g, and I added my thoughts here: #764 (comment).

kannon92

kannon92 commented on Feb 7, 2025

@kannon92
ContributorAuthor

Post from aldo: #764 (comment)

In openshift, we are going to vendor this repo in our fork due to hermetic build requirements.

We can close this if we feel that this is not worth putting in upstream. We still have to do it on our downstream builds but it is what it is.

ahg-g

ahg-g commented on Feb 7, 2025

@ahg-g
Contributor

+1 to not invest in this now

kannon92

kannon92 commented on Feb 7, 2025

@kannon92
ContributorAuthor

/close

k8s-ci-robot

k8s-ci-robot commented on Feb 7, 2025

@k8s-ci-robot
Contributor

@kannon92: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Participants

    @kannon92@k8s-ci-robot@andreyvelich@ahg-g

    Issue actions

      Vendor dependencies · Issue #763 · kubernetes-sigs/jobset