Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to customize exclusiveness by selecting which pods the job should not co-exist with #40

Closed
Tracked by #43
ahg-g opened this issue Apr 18, 2023 · 2 comments
Assignees

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Apr 18, 2023

Currently the exclusive option enforces exclusiveness again other jobs, we can make that as a default and allow users to customize this choice by adding a labelSelector to the api.

The labelSelector would be merged with the one used in the antiAffinity term that excludes the job itself.

podSelector *metav1.LabelSelector `json:"podSelector,omitempty"`

defaults to:

metav1.LabelSelector{MatchExpressions: []metav1.LabelSelectorRequirement{{
			Key:      jobset.JobNameKey,
			Operator: metav1.LabelSelectorOpExists,
}
@danielvegamyhre
Copy link
Contributor

/assign

@ahg-g
Copy link
Contributor Author

ahg-g commented May 1, 2023

superseded by #75

@ahg-g ahg-g closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants