Skip to content

[release-1.14] Add Attach Limit for Hyperdisk + Gen4 VMs #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

[release-1.14] Add Attach Limit for Hyperdisk + Gen4 VMs #2067

merged 2 commits into from
Apr 30, 2025

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2064

/assign sunnylovestiramisu

Add Attach Limit for Hyperdisk + Gen4 VMs

sunnylovestiramisu and others added 2 commits April 29, 2025 17:04
@sunnylovestiramisu
Add Attach Limit for Hyperdisk + Gen4 VMs
3e284a2
@jsafrane
Fix hyperdisk attach limits
a5f1354 
Reserve 1 attachment for the root / OS disk when reporting nr. of
attachable hyperdisks.
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 29, 2025
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 29, 2025
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2025
@sunnylovestiramisu
Copy link
Contributor

Flaky snapshot test
/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@sunnylovestiramisu
Copy link
Contributor

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@sunnylovestiramisu
Copy link
Contributor

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@sunnylovestiramisu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@sunnylovestiramisu
Copy link
Contributor

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

2 similar comments
@sunnylovestiramisu
Copy link
Contributor

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@sunnylovestiramisu
Copy link
Contributor

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 a5f1354 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022 a5f1354 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration a5f1354 link true /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mattcary
Copy link
Contributor

known flakes on snapshot tests, force-merging

@mattcary mattcary merged commit 9110541 into kubernetes-sigs:release-1.14 Apr 30, 2025
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songjiaxun songjiaxun Awaiting requested review from songjiaxun

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

Assignees

@sunnylovestiramisu sunnylovestiramisu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @sunnylovestiramisu @k8s-ci-robot @mattcary @jsafrane