Fix units for cache size while calculating chunk size for LVM #2007
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/S
|
/cherry-pick release-1.17 |
|
@Sneha-at: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
publishContext[common.ContextDataCacheSize] = defaultLocalSsdCacheSize needs to be changed to a number? |
| @@ -563,7 +563,7 @@ func isCachingSetup(mainLvName string) (error, bool) { | |||
| func fetchChunkSizeKiB(cacheSize string) (string, error) { | |||
| var chunkSize float64 | |||
|
|
|||
| cacheSizeInt, err := common.ConvertGiStringToInt64(cacheSize) | |||
| cacheSizeInt, err := strconv.ParseInt(cacheSize, 10, 64) | |||
There was a problem hiding this comment.
The comment below needs to be updated too? "Chunksize should be divisible by 32Kib so we need (chunksize/32*1024)321024"?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sneha-at, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@Sneha-at: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test pull-gcp-compute-persistent-disk-csi-driver-e2e |
|
@Sneha-at: new pull request created: #2012 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
What this PR does / why we need it:
Currently the cache size unit isn't passed along with the cache size causing conversion issues downstream
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: