-
Notifications
You must be signed in to change notification settings - Fork 158
Pass performance parameters when creating regional disks. #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill, tonyzhc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think this ends up being a lot more readable, and I didn't detect any changes in actual behavior. I think breaking up the disk spec construction and the insertion is a really good plan for keeping this clean going forward!
@tonyzhc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
/retest failed |
@tonyzhc: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 |
/cherry-pick release-1.17 |
@tonyzhc: new pull request created: #1992 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
What this PR does / why we need it:
We found a bug during bugbash that performance parameters are not passed to
insertRegionalDisks
. I decided to consolidate the two variants of the function (insertZonalDisks
andinsertRegionalDisks
), because they share almost the same logic except some non-applicable parameters (e.g. storage pool) and differences on the GCE interface. I believe that this will prevent future slips similar to this bug.Which issue(s) this PR fixes:
Fixes b/402880628
Special notes for your reviewer:
Does this PR introduce a user-facing change?: