Skip to content

Pass performance parameters when creating regional disks. #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

tonyzhc
Copy link
Contributor

@tonyzhc tonyzhc commented Mar 13, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:
We found a bug during bugbash that performance parameters are not passed to insertRegionalDisks. I decided to consolidate the two variants of the function (insertZonalDisks and insertRegionalDisks), because they share almost the same logic except some non-applicable parameters (e.g. storage pool) and differences on the GCE interface. I believe that this will prevent future slips similar to this bug.

Which issue(s) this PR fixes:

Fixes b/402880628

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 13, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 13, 2025
@amacaskill
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, tonyzhc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 13, 2025
@amacaskill
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2025
Copy link

@nathanielford nathanielford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think this ends up being a lot more readable, and I didn't detect any changes in actual behavior. I think breaking up the disk spec construction and the insertion is a really good plan for keeping this clean going forward!

@k8s-ci-robot
Copy link
Contributor

@tonyzhc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 15e5a6f link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@amacaskill
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2025
@tonyzhc
Copy link
Contributor Author

tonyzhc commented Mar 13, 2025

/retest failed

@k8s-ci-robot
Copy link
Contributor

@tonyzhc: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-gcp-compute-persistent-disk-csi-driver-e2e
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
/test pull-gcp-compute-persistent-disk-csi-driver-sanity
/test pull-gcp-compute-persistent-disk-csi-driver-unit
/test pull-gcp-compute-persistent-disk-csi-driver-verify

The following commands are available to trigger optional jobs:

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

Use /test all to run all jobs.

In response to this:

/retest failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tonyzhc
Copy link
Contributor Author

tonyzhc commented Mar 13, 2025

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

@k8s-ci-robot k8s-ci-robot merged commit a915c52 into kubernetes-sigs:master Mar 13, 2025
7 of 8 checks passed
@tonyzhc
Copy link
Contributor Author

tonyzhc commented Mar 14, 2025

/cherry-pick release-1.17

@k8s-infra-cherrypick-robot

@tonyzhc: new pull request created: #1992

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants