Do not use beta API for hyperdisk in multi-writer mode.

[karkunpavan]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Hyper disk multi-writer support is now in compute/v1 but the persistent disk csi driver still calls v0.beta which leads a error while creating a hyperdisk with multi-writer mode. Error:

Warning ProvisioningFailed 31m (x15 over 57m) pd.csi.storage.gke.io_wduan-1030a-g-vdnqh-master-0_dc46e9f6-1725-4f15-922c-99f0e281e102 failed to provision volume with StorageClass
"balanced-storage": rpc error: code = InvalidArgument desc = CreateVolume failed: rpc error: code = InvalidArgument desc = CreateVolume failed to create single zonal disk pvc-0b65d680-636b-46c6-876d-d3a6c412c3ef: failed to insert zonal disk: unknown Insert disk error:
googleapi: Error 400: Invalid value for field 'resource.multiWriter': 'true'.
Cannot specify the multi writer field for 'hyperdisk-balanced' disks,
please use access mode instead., invalid%!v(MISSING)

To fix this we will call the v1 API which accepts accessMode = ReadWriteMany.

Which issue(s) this PR fixes:

Fixes #1863

Special notes for your reviewer:

• Discussed this issue and the fix with Matthew
• Making this change only for disk types hyperdisk*, multi-writer support for other disk types is not the focus of this fix.

Does this PR introduce a user-facing change?:

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: karkunpavan / name: Pavan Karkun (4168542, 8081b51, 35d3d55)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karkunpavan
Once this PR has been reviewed and has the lgtm label, please assign mattcary for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @karkunpavan!

It looks like this is your first PR to kubernetes-sigs/gcp-compute-persistent-disk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-compute-persistent-disk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @karkunpavan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mattcary]

/ok-to-test

[karkunpavan]

Detailed code changes as requested. Updated the PR with all of these code changes.

1. In insertZonalDisk() PD CSI driver currently calls beta APIs when multi-writer is set. We need to add a switch based on disk type. For hyperdisk use v1 API and for persistent disks use beta APIs.

2. Similar changes needed in insertRegionalDisk()

3. AccessMode flag is already set here and no changes needed to explicitly set it for hyperdisks

4. GetMultiWriter() currently thinks that v1 APIs do not support multi-writer and this needs to be fixed. We should return a True when AccessMode == READ_WRITE_MANY

5. Remove comments about hyperdisk not supporting multi-writer

[karkunpavan]

/retest-required

The failures are SSH timeouts which seem to be unrelated to my changes.

[karkunpavan]

/retest - seems like a flaky test which timed out.

[k8s-ci-robot]

@karkunpavan: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

• /test pull-gcp-compute-persistent-disk-csi-driver-e2e
• /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
• /test pull-gcp-compute-persistent-disk-csi-driver-sanity
• /test pull-gcp-compute-persistent-disk-csi-driver-unit
• /test pull-gcp-compute-persistent-disk-csi-driver-verify

The following commands are available to trigger optional jobs:

• /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019

Use /test all to run the following jobs that were automatically triggered:

• pull-gcp-compute-persistent-disk-csi-driver-e2e
• pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
• pull-gcp-compute-persistent-disk-csi-driver-sanity
• pull-gcp-compute-persistent-disk-csi-driver-unit
• pull-gcp-compute-persistent-disk-csi-driver-verify

In response to this:

/retest - seems like a flaky test which timed out.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[karkunpavan]

/retest

[k8s-ci-robot]

@karkunpavan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gcp-compute-persistent-disk-csi-driver-verify	4168542	link	true	/test pull-gcp-compute-persistent-disk-csi-driver-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.