-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TLS options validation as final sig-network review follow up #886
Adding TLS options validation as final sig-network review follow up #886
Conversation
6d4088a
to
5847f40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Note your release note has "TCP" instead of "TLS"
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Great change, just needs the docstring for |
5847f40
to
a40d655
Compare
/lgtm /hold |
/lgtm |
/hold cancel |
What type of PR is this?
/kind cleanup
/kind api-change
What this PR does / why we need it:
I found a comment from @khenidak that I'd missed from the original sig-network review suggesting more thorough validation here. This adds generic "AnnotationKey" and "AnnotationValue" types in hopes that they'll be useful for more than just TLS options in the future.
Does this PR introduce a user-facing change?: