Documenting Route attachment for v1alpha2 #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
the
approved
|
Adding a hold until #754 merges, will also add more examples at that point. |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
robscott
force-pushed
the
gep-724-docs
branch
3 times, most recently
from
143cfaf
to
02bb4f9
Compare
bowei
reviewed
Aug 12, 2021
bowei
reviewed
Aug 12, 2021
bowei
reviewed
Aug 12, 2021
|
/hold |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
robscott
force-pushed
the
gep-724-docs
branch
2 times, most recently
from
60965e3
to
6a2b5ba
Compare
|
Thanks for the feedback @bowei! I think I've updated everything, PTAL. |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
Thanks for the feedback @jpeach, just pushed updates, PTAL. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
youngnick
approved these changes
Aug 13, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeach, robscott, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This is a follow up to #754 and provides documentation for GEP #724.
Does this PR introduce a user-facing change?:
Deploy Previews: