-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish webhook docker image to k8s production container registry #916
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Update: We are working on this. @youngnick updated the build script and we released v0.4.2 to test it out, unfortunately not quite working yet: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-gateway-api-push-images/1503442368546738176 /lifecycle frozen |
The folks at ingress-nginx have really great RELEASE docs that include how they handle promoting images: https://github.com/kubernetes/ingress-nginx/blob/main/RELEASE.md#3-promote-the-images In short:
This means that once we do this, our release YAMLs will be able to use I think we should keep our |
That sounds good as long as we make sure to have YAML in the release tag pointing to the production image. I expect implemeneters to point to the repo with a release tag to do installation. That is what we do in our docs as well: https://gateway-api.sigs.k8s.io/v1alpha2/guides/getting-started/#installing-gateway-api-crds-manually |
@youngnick where did we leave off with this one? |
It's still TODO, but I think that following what the ingress-nginx folks do seems like the way to go to me. |
I've taken a shot at this. Would like to direct attention to PR kubernetes/k8s.io#5030 as that is outside this repo and might get missed |
What would you like to be added:
Why this is needed:
We should have users relying on the production image rather than the staging ones.
Additional context:
The text was updated successfully, but these errors were encountered: