Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish webhook docker image to k8s production container registry #916

Closed
Tracked by #1005
hbagdi opened this issue Oct 25, 2021 · 8 comments · Fixed by #1879
Closed
Tracked by #1005

Publish webhook docker image to k8s production container registry #916

hbagdi opened this issue Oct 25, 2021 · 8 comments · Fixed by #1879
Assignees
Labels
area/webhook help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-blocker MUST be completed to complete the milestone
Milestone

Comments

@hbagdi
Copy link
Contributor

hbagdi commented Oct 25, 2021

What would you like to be added:

  • Publish a production image of 0.4.0 tag for admission-server
  • Document the steps necessary so that future maintainers doing a release can do this

Why this is needed:

We should have users relying on the production image rather than the staging ones.

Additional context:

@hbagdi hbagdi added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 25, 2021
@hbagdi hbagdi added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Dec 14, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2022
@robscott
Copy link
Member

Update: We are working on this. @youngnick updated the build script and we released v0.4.2 to test it out, unfortunately not quite working yet: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-gateway-api-push-images/1503442368546738176

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 14, 2022
@robscott robscott removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 14, 2022
@youngnick
Copy link
Contributor

Okay, with #1043 and #1044 merged, we've validated that we've got images correctly labelled and in the staging GCR. Now to figure out how to get it to prod.

@youngnick
Copy link
Contributor

The folks at ingress-nginx have really great RELEASE docs that include how they handle promoting images: https://github.com/kubernetes/ingress-nginx/blob/main/RELEASE.md#3-promote-the-images

In short:

  • we PR to kubernetes/k8s.io, adding the SHA of the image we sent to staging to a YAML file.
  • Once that PR is merged, that tag (and only that tag) will be promoted.

This means that once we do this, our release YAMLs will be able to use k8s.gcr.io/gateway-api/controller:<semver>.

I think we should keep our master YAMLs using the staging repo and :latest, maybe?

@hbagdi
Copy link
Contributor Author

hbagdi commented Apr 1, 2022

I think we should keep our master YAMLs using the staging repo and :latest, maybe?

That sounds good as long as we make sure to have YAML in the release tag pointing to the production image. I expect implemeneters to point to the repo with a release tag to do installation. That is what we do in our docs as well: https://gateway-api.sigs.k8s.io/v1alpha2/guides/getting-started/#installing-gateway-api-crds-manually

@youngnick youngnick added this to the v0.6.0 milestone Aug 4, 2022
@youngnick youngnick mentioned this issue Sep 15, 2022
1 task
@robscott robscott modified the milestones: v0.6.0, v0.7.0 Sep 26, 2022
@shaneutt shaneutt added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Feb 21, 2023
@shaneutt
Copy link
Member

@youngnick where did we leave off with this one?

@youngnick
Copy link
Contributor

It's still TODO, but I think that following what the ingress-nginx folks do seems like the way to go to me.

@shaneutt shaneutt added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Feb 22, 2023
@shaneutt shaneutt modified the milestones: v0.7.0, v1.0.0 Feb 22, 2023
@shaneutt shaneutt added release-blocker MUST be completed to complete the milestone and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Mar 14, 2023
@gauravkghildiyal
Copy link
Member

I've taken a shot at this. Would like to direct attention to PR kubernetes/k8s.io#5030 as that is outside this repo and might get missed

@shaneutt shaneutt modified the milestones: v1.0.0, v0.7.0 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/webhook help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-blocker MUST be completed to complete the milestone
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants